Add d/aws_identitystore_groups

[aristosvo]

Description

Follow-up of #31681, big thanks for @liath laying the foundation for this one.

Updated to plugin framework

Adds a data source for listing all groups in an Identity Store instance. Part of a few PRs to cover #26770.

The acceptance test is weird and I'd appreciate guidance on what to do there. The issue is that Identity Store instances are account wide so we can't guarantee there's only one group in the results or the order of the results. As far as I could find there isn't a way to say in the AttrPair checks "check these nested fields in any item of this list and compare those to these attributes on this other resource". So we're left with doing that in a custom test function.

Of course, server-side filter would likely help here but aws-sdk says that functionality is deprecated. :(

The importance of this for us a customer is mainly to automate SSO assignments within our landing zone and account vending, otherwise using scripts covering this missing functionality.

Relations

Followup of #31681
Partly closes #26770

References

@bschaatsbergen wanted to help me move this forward

Output from Acceptance Testing

% make testacc TESTS=TestAccIdentityStoreGroupsDataSource_ PKG=identitystore  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/identitystore/... -v -count 1 -parallel 20 -run='TestAccIdentityStoreGroupsDataSource_'  -timeout 360m
=== RUN   TestAccIdentityStoreGroupsDataSource_basic
=== PAUSE TestAccIdentityStoreGroupsDataSource_basic
=== CONT  TestAccIdentityStoreGroupsDataSource_basic
--- PASS: TestAccIdentityStoreGroupsDataSource_basic (12.22s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/identitystore      16.670s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[bschaatsbergen]

Hey @aristosvo, great work! Thanks for picking this up. The PR looks really good.

Let me check with the team to see if we have an AWS account with an SSO instance set up already. Meanwhile I've left a few comments.

[bschaatsbergen]

LGTM 🚀 - looped in the AWS team internally to run the tests against an AWS account with SSO instances configured.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIdentityStoreGroupsDataSource_' PKG=identitystore
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/identitystore/... -v -count 1 -parallel 20  -run=TestAccIdentityStoreGroupsDataSource_ -timeout 360m
=== RUN   TestAccIdentityStoreGroupsDataSource_basic
=== PAUSE TestAccIdentityStoreGroupsDataSource_basic
=== CONT  TestAccIdentityStoreGroupsDataSource_basic
--- PASS: TestAccIdentityStoreGroupsDataSource_basic (18.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	29.616s

[ewbankkit]

@aristosvo Thanks for the contribution 🎉 👏.

[bschaatsbergen]

Thanks for your contributions @aristosvo & @liath 🎉👏

[aristosvo]

Thank you @bschaatsbergen for helping us push it to the finish line 🏋️🏁

[github-actions]

This functionality has been released in v5.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.