Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump go version to 1.22 #36996

Merged
merged 5 commits into from Apr 19, 2024
Merged

bump go version to 1.22 #36996

merged 5 commits into from Apr 19, 2024

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Apr 19, 2024

Description

Relations

References

Go 1.22 release notes.

Output from Acceptance Testing

% make sane

make: sane Check (48 tests of Top 30 resources)
make: like 'sanity' except full output and stops soon after 1st error
make: NOTE: NOT an exhaustive set of tests! Finds big problems only.
--- PASS: TestAccIAMPolicy_policyDuplicateKeys (4.30s)
--- PASS: TestAccIAMRole_disappears (36.65s)
--- PASS: TestAccIAMRolePolicy_unknownsInPolicy (37.07s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nullOverlappingResourceTag (41.19s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_emptyResourceTag (42.75s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag (42.91s)
--- PASS: TestAccIAMRole_namePrefix (43.19s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_emptyResourceTag (43.26s)
--- PASS: TestAccIAMRolePolicy_basic (43.47s)
--- PASS: TestAccIAMRole_basic (43.71s)
--- PASS: TestAccIAMPolicy_basic (43.74s)
--- PASS: TestAccIAMInstanceProfile_basic (39.61s)
--- PASS: TestAccIAMPolicy_tags_null (52.42s)
--- PASS: TestAccIAMPolicyDocumentDataSource_sourceConflicting (24.14s)
--- PASS: TestAccIAMPolicyDocumentDataSource_basic (23.74s)
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Replace (62.40s)
--- PASS: TestAccIAMPolicy_tags_AddOnUpdate (65.20s)
--- PASS: TestAccIAMPolicy_policy (65.58s)
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnCreate (71.89s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_nullNonOverlappingResourceTag (37.45s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_nullOverlappingResourceTag (37.21s)
--- PASS: TestAccIAMRole_InlinePolicy_basic (92.08s)
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add (99.62s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_updateToProviderOnly (57.36s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_updateToResourceOnly (57.57s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_updateToResourceOnly (61.34s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_updateToProviderOnly (62.39s)
--- PASS: TestAccIAMRolePolicyAttachment_disappears (29.85s)
--- PASS: TestAccIAMRolePolicyAttachment_Disappears_role (26.75s)
--- PASS: TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Replace (57.63s)
--- PASS: TestAccIAMInstanceProfile_tags_EmptyTag_OnCreate (62.04s)
--- PASS: TestAccIAMInstanceProfile_tags_AddOnUpdate (53.49s)
--- PASS: TestAccIAMPolicy_tags (125.96s)
--- PASS: TestAccIAMInstanceProfile_tags (127.24s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_overlapping (84.02s)
--- PASS: TestAccIAMInstanceProfile_tags_null (36.06s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_nonOverlapping (85.73s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_overlapping (86.08s)
--- PASS: TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Add (70.65s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nonOverlapping (68.43s)
--- PASS: TestAccIAMRolePolicyAttachment_basic (36.07s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_providerOnly (97.02s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_providerOnly (76.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	147.650s
--- PASS: TestAccLogsGroup_multiple (14.21s)
--- PASS: TestAccLogsGroup_basic (17.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	22.747s
--- PASS: TestAccVPCSubnet_basic (26.79s)
--- PASS: TestAccVPCRouteTable_basic (27.48s)
--- PASS: TestAccVPCSecurityGroup_basic (29.03s)
--- PASS: TestAccVPCSecurityGroup_vpcAllEgress (29.05s)
--- PASS: TestAccVPCRouteTableAssociation_Subnet_basic (29.79s)
--- PASS: TestAccVPCDataSource_basic (32.04s)
--- PASS: TestAccVPC_tenancy (46.68s)
--- PASS: TestAccVPCSecurityGroup_egressMode (47.75s)
--- PASS: TestAccVPCSecurityGroupRule_protocolChange (52.90s)
--- PASS: TestAccVPCSecurityGroupRule_race (137.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	147.185s
--- PASS: TestAccECSTaskDefinition_basic (24.32s)
--- PASS: TestAccECSService_basic (67.96s)
--- PASS: TestAccECSService_basicImport (184.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	205.663s
--- PASS: TestAccELBV2TargetGroup_basic (22.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	35.627s
--- PASS: TestAccKMSKey_basic (23.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	40.802s
--- PASS: TestAccLambdaPermission_basic (32.58s)
--- PASS: TestAccLambdaFunction_basic (39.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	44.718s
--- PASS: TestAccMetaRegionDataSource_basic (10.48s)
--- PASS: TestAccMetaPartitionDataSource_basic (10.58s)
--- PASS: TestAccMetaRegionDataSource_endpoint (12.56s)
--- PASS: TestAccMetaRegionDataSource_endpointAndName (12.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/meta	21.495s
--- PASS: TestAccRoute53ZoneDataSource_name (60.59s)
--- PASS: TestAccRoute53Record_basic (133.75s)
--- PASS: TestAccRoute53Record_Latency_basic (168.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	181.151s
--- PASS: TestAccS3BucketPublicAccessBlock_basic (21.43s)
--- PASS: TestAccS3Bucket_Basic_basic (21.57s)
--- PASS: TestAccS3BucketPolicy_basic (21.58s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (32.83s)
--- PASS: TestAccS3BucketACL_updateACL (32.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	49.505s
--- PASS: TestAccSecretsManagerSecret_basic (13.92s)
--- PASS: TestAccSecretsManagerSecret_basicReplica (17.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager	37.963s
--- PASS: TestAccSTSCallerIdentityDataSource_basic (9.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sts	32.961s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. linter Pertains to changes to or issues with the various linters. skaff Issues and pull requested related to the skaff tool labels Apr 19, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 19, 2024
@johnsonaj johnsonaj marked this pull request as ready for review April 19, 2024 16:15
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Apr 19, 2024
@ewbankkit
Copy link
Contributor

Also need to update docs/development-environment.md.

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit ewbankkit added the go Pull requests that update Go code label Apr 19, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Might be worth a changelog note entry?

@johnsonaj johnsonaj merged commit f1d8b2e into main Apr 19, 2024
44 checks passed
@johnsonaj johnsonaj deleted the upgrade-go-version-122 branch April 19, 2024 19:51
@github-actions github-actions bot added this to the v5.47.0 milestone Apr 19, 2024
github-actions bot pushed a commit that referenced this pull request Apr 19, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 26, 2024
Copy link

This functionality has been released in v5.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code linter Pertains to changes to or issues with the various linters. provider Pertains to the provider itself, rather than any interaction with AWS. size/S Managed by automation to categorize the size of a PR. skaff Issues and pull requested related to the skaff tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants