Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f-aws_transfer_server support for sftp authentication methods #37015

Merged
merged 9 commits into from Apr 24, 2024

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Apr 20, 2024

Description

Relations

Closes #32900

References

Output from Acceptance Testing

% make testacc TESTS=TestAccTransfer_serial PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccTransfer_serial'  -timeout 360m
=== RUN   TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT  TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/APIGateway
=== RUN   TestAccTransfer_serial/Server/SftpAuthenticationMethods
=== RUN   TestAccTransfer_serial/Server/UpdateSftpAuthenticationMethods
=== RUN   TestAccTransfer_serial/Server/basic
--- PASS: TestAccTransfer_serial (681.91s)
    --- PASS: TestAccTransfer_serial/Server (681.91s)
        --- PASS: TestAccTransfer_serial/Server/APIGateway (168.65s)
        --- PASS: TestAccTransfer_serial/Server/SftpAuthenticationMethods (165.04s)
        --- PASS: TestAccTransfer_serial/Server/UpdateSftpAuthenticationMethods (176.12s)
        --- PASS: TestAccTransfer_serial/Server/basic (172.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	695.612s

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/transfer Issues and PRs that pertain to the transfer service. labels Apr 20, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 20, 2024
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Apr 20, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 23, 2024
@ewbankkit ewbankkit self-assigned this Apr 24, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 24, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTransfer_serial/Server' PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/transfer/... -v -count 1 -parallel 20  -run=TestAccTransfer_serial/Server -timeout 360m
=== RUN   TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT  TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/VPCAddressAllocationIDsSecurityGroupIDs
=== RUN   TestAccTransfer_serial/Server/VPCSecurityGroupIDs
=== RUN   TestAccTransfer_serial/Server/tags
=== RUN   TestAccTransfer_serial/Server/DirectoryService
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCToPublic
=== RUN   TestAccTransfer_serial/Server/VPCAddressAllocationIDs
=== RUN   TestAccTransfer_serial/Server/DataSourceServiceManaged
=== RUN   TestAccTransfer_serial/Server/VPC
=== RUN   TestAccTransfer_serial/Server/HostKey
=== RUN   TestAccTransfer_serial/Server/ProtocolDetails
=== RUN   TestAccTransfer_serial/Server/SecurityPolicy
=== RUN   TestAccTransfer_serial/Server/SftpAuthenticationMethods
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPCAddressAllocationIDs
=== RUN   TestAccTransfer_serial/Server/DataSourceBasic
=== RUN   TestAccTransfer_serial/Server/Domain
=== RUN   TestAccTransfer_serial/Server/ForceDestroy
=== RUN   TestAccTransfer_serial/Server/LambdaFunction
=== RUN   TestAccTransfer_serial/Server/AuthenticationLoginBanners
=== RUN   TestAccTransfer_serial/Server/SecurityPolicyFIPS
=== RUN   TestAccTransfer_serial/Server/Workflow
=== RUN   TestAccTransfer_serial/Server/disappears
=== RUN   TestAccTransfer_serial/Server/Protocols
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPC
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPC
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCAddressAllocationIDs
=== RUN   TestAccTransfer_serial/Server/basic
=== RUN   TestAccTransfer_serial/Server/APIGatewayForceDestroy
=== RUN   TestAccTransfer_serial/Server/UpdateSftpAuthenticationMethods
=== RUN   TestAccTransfer_serial/Server/StructuredLogDestinations
=== RUN   TestAccTransfer_serial/Server/VPCEndpointID
=== RUN   TestAccTransfer_serial/Server/APIGateway
=== RUN   TestAccTransfer_serial/Server/DataSourceAPIGateway
=== RUN   TestAccTransfer_serial/Server/S3StorageOptions
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCSecurityGroupIDs
--- PASS: TestAccTransfer_serial (7426.66s)
    --- PASS: TestAccTransfer_serial/Server (7426.66s)
        --- PASS: TestAccTransfer_serial/Server/VPCAddressAllocationIDsSecurityGroupIDs (213.37s)
        --- PASS: TestAccTransfer_serial/Server/VPCSecurityGroupIDs (62.39s)
        --- PASS: TestAccTransfer_serial/Server/tags (218.49s)
        --- PASS: TestAccTransfer_serial/Server/DirectoryService (904.27s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCToPublic (224.90s)
        --- PASS: TestAccTransfer_serial/Server/VPCAddressAllocationIDs (251.74s)
        --- PASS: TestAccTransfer_serial/Server/DataSourceServiceManaged (192.85s)
        --- PASS: TestAccTransfer_serial/Server/VPC (166.72s)
        --- PASS: TestAccTransfer_serial/Server/HostKey (164.07s)
        --- PASS: TestAccTransfer_serial/Server/ProtocolDetails (204.51s)
        --- PASS: TestAccTransfer_serial/Server/SecurityPolicy (246.94s)
        --- PASS: TestAccTransfer_serial/Server/SftpAuthenticationMethods (198.71s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPCAddressAllocationIDs (445.37s)
        --- PASS: TestAccTransfer_serial/Server/DataSourceBasic (160.39s)
        --- PASS: TestAccTransfer_serial/Server/Domain (194.05s)
        --- PASS: TestAccTransfer_serial/Server/ForceDestroy (195.32s)
        --- PASS: TestAccTransfer_serial/Server/LambdaFunction (213.33s)
        --- PASS: TestAccTransfer_serial/Server/AuthenticationLoginBanners (165.05s)
        --- PASS: TestAccTransfer_serial/Server/SecurityPolicyFIPS (204.28s)
        --- PASS: TestAccTransfer_serial/Server/Workflow (216.59s)
        --- PASS: TestAccTransfer_serial/Server/disappears (195.24s)
        --- PASS: TestAccTransfer_serial/Server/Protocols (225.62s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPC (132.40s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPC (292.30s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCAddressAllocationIDs (184.56s)
        --- PASS: TestAccTransfer_serial/Server/basic (180.49s)
        --- PASS: TestAccTransfer_serial/Server/APIGatewayForceDestroy (202.17s)
        --- PASS: TestAccTransfer_serial/Server/UpdateSftpAuthenticationMethods (218.21s)
        --- PASS: TestAccTransfer_serial/Server/StructuredLogDestinations (209.81s)
        --- PASS: TestAccTransfer_serial/Server/VPCEndpointID (70.00s)
        --- PASS: TestAccTransfer_serial/Server/APIGateway (168.70s)
        --- PASS: TestAccTransfer_serial/Server/DataSourceAPIGateway (194.14s)
        --- PASS: TestAccTransfer_serial/Server/S3StorageOptions (213.12s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCSecurityGroupIDs (96.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	7438.286s

@ewbankkit
Copy link
Contributor

@nikhil-goenka Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 7f98add into hashicorp:main Apr 24, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.47.0 milestone Apr 24, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 26, 2024
Copy link

This functionality has been released in v5.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/transfer Issues and PRs that pertain to the transfer service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_transfer_server doesn't have authentication method
3 participants