Fix aws_ec2_capacity_reservation causing failure if removed outside Terraform

[dhrkumar]

Description

Fix a bug where if a capacity reservation is deleted/removed from AWS account outside Terraform while the resource is still in Terraform state, refresh/read and delete actions result in failure.

Relations

Closes #36716

References

Output from Acceptance Testing

% make testacc TESTS='TestAccEC2CapacityReservation_' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run='TestAccEC2CapacityReservation_'  -timeout 360m
=== RUN   TestAccEC2CapacityReservation_basic
=== PAUSE TestAccEC2CapacityReservation_basic
=== RUN   TestAccEC2CapacityReservation_disappears
=== PAUSE TestAccEC2CapacityReservation_disappears
=== RUN   TestAccEC2CapacityReservation_ebsOptimized
=== PAUSE TestAccEC2CapacityReservation_ebsOptimized
=== RUN   TestAccEC2CapacityReservation_endDate
=== PAUSE TestAccEC2CapacityReservation_endDate
=== RUN   TestAccEC2CapacityReservation_endDateType
=== PAUSE TestAccEC2CapacityReservation_endDateType
=== RUN   TestAccEC2CapacityReservation_ephemeralStorage
=== PAUSE TestAccEC2CapacityReservation_ephemeralStorage
=== RUN   TestAccEC2CapacityReservation_instanceCount
=== PAUSE TestAccEC2CapacityReservation_instanceCount
=== RUN   TestAccEC2CapacityReservation_instanceMatchCriteria
=== PAUSE TestAccEC2CapacityReservation_instanceMatchCriteria
=== RUN   TestAccEC2CapacityReservation_instanceType
=== PAUSE TestAccEC2CapacityReservation_instanceType
=== RUN   TestAccEC2CapacityReservation_tags
=== PAUSE TestAccEC2CapacityReservation_tags
=== RUN   TestAccEC2CapacityReservation_tenancy
=== PAUSE TestAccEC2CapacityReservation_tenancy
=== CONT  TestAccEC2CapacityReservation_basic
=== CONT  TestAccEC2CapacityReservation_instanceCount
=== CONT  TestAccEC2CapacityReservation_tags
--- PASS: TestAccEC2CapacityReservation_basic (41.20s)
=== CONT  TestAccEC2CapacityReservation_tenancy
--- PASS: TestAccEC2CapacityReservation_instanceCount (61.91s)
=== CONT  TestAccEC2CapacityReservation_endDate
--- PASS: TestAccEC2CapacityReservation_tenancy (34.84s)
=== CONT  TestAccEC2CapacityReservation_ephemeralStorage
--- PASS: TestAccEC2CapacityReservation_tags (77.91s)
=== CONT  TestAccEC2CapacityReservation_endDateType
--- PASS: TestAccEC2CapacityReservation_ephemeralStorage (33.46s)
=== CONT  TestAccEC2CapacityReservation_ebsOptimized
--- PASS: TestAccEC2CapacityReservation_endDate (50.96s)
=== CONT  TestAccEC2CapacityReservation_disappears
--- PASS: TestAccEC2CapacityReservation_ebsOptimized (32.74s)
=== CONT  TestAccEC2CapacityReservation_instanceType
--- PASS: TestAccEC2CapacityReservation_disappears (31.19s)
=== CONT  TestAccEC2CapacityReservation_instanceMatchCriteria
--- PASS: TestAccEC2CapacityReservation_endDateType (73.28s)
--- PASS: TestAccEC2CapacityReservation_instanceMatchCriteria (33.24s)
--- PASS: TestAccEC2CapacityReservation_instanceType (49.51s)
PASS
ok   [github.com/hashicorp/terraform-provider-aws/internal/service/ec2](http://github.com/hashicorp/terraform-provider-aws/internal/service/ec2) 191.983s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[dhrkumar]

@ewbankkit please review this small bug fix contribution

[dhrkumar]

@ewbankkit @justinretzolk can this extra small bug fix be reviewed and merged? It cause issues in refresh and resource has to be manually removed from state file.

[ewbankkit]

LGTM 🚀.

[ewbankkit]

@dhrkumar Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!