Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/bedrockagent data source #37158

Merged
merged 17 commits into from May 3, 2024
Merged

Feature/bedrockagent data source #37158

merged 17 commits into from May 3, 2024

Conversation

markoskandylis
Copy link
Contributor

@markoskandylis markoskandylis commented Apr 29, 2024 •
edited by ewbankkit

Description

New resource for bedrock Agent Data Source
https://docs.aws.amazon.com/bedrock/latest/APIReference/API_agent_CreateDataSource.html

Relations

Closes #35543.

References

Output from Acceptance Testing

make testacc TESTARGS='-run=TestAccBedrockAgent_serial/DataSource' PKG=bedrockagent  ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/bedrockagent/... -v -count 1 -parallel 1  -run=TestAccBedrockAgent_serial/DataSource -timeout 360m
=== RUN   TestAccBedrockAgent_serial
=== PAUSE TestAccBedrockAgent_serial
=== CONT  TestAccBedrockAgent_serial
=== RUN   TestAccBedrockAgent_serial/DataSource
=== RUN   TestAccBedrockAgent_serial/DataSource/basic
=== RUN   TestAccBedrockAgent_serial/DataSource/disappears
=== RUN   TestAccBedrockAgent_serial/DataSource/full
--- PASS: TestAccBedrockAgent_serial (53.90s)
    --- PASS: TestAccBedrockAgent_serial/DataSource (53.90s)
        --- PASS: TestAccBedrockAgent_serial/DataSource/basic (19.52s)
        --- PASS: TestAccBedrockAgent_serial/DataSource/disappears (16.18s)
        --- PASS: TestAccBedrockAgent_serial/DataSource/full (18.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent	59.303s

...

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. labels Apr 29, 2024
@markoskandylis markoskandylis marked this pull request as ready for review April 29, 2024 14:41
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Apr 29, 2024
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 30, 2024
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed new-data-source Introduces a new data source. labels May 1, 2024
@ewbankkit ewbankkit self-assigned this May 1, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 1, 2024
@ewbankkit ewbankkit mentioned this pull request May 2, 2024
Closed
6 tasks
ewbankkit
ewbankkit approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccBedrockAgent_serial/DataSource/basic' PKG=bedrockagent
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/bedrockagent/... -v -count 1 -parallel 20  -run=TestAccBedrockAgent_serial/DataSource/basic -timeout 720m
=== RUN   TestAccBedrockAgent_serial
=== PAUSE TestAccBedrockAgent_serial
=== CONT  TestAccBedrockAgent_serial
=== RUN   TestAccBedrockAgent_serial/DataSource
=== RUN   TestAccBedrockAgent_serial/DataSource/basic
--- PASS: TestAccBedrockAgent_serial (1889.28s)
    --- PASS: TestAccBedrockAgent_serial/DataSource (1889.28s)
        --- PASS: TestAccBedrockAgent_serial/DataSource/basic (1889.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent	1900.290s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccBedrockAgent_serial/DataSource/disappears\|TestAccBedrockAgent_serial/DataSource/full' PKG=bedrockagent
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/bedrockagent/... -v -count 1 -parallel 20  -run=TestAccBedrockAgent_serial/DataSource/disappears\|TestAccBedrockAgent_serial/DataSource/full -timeout 720m
=== RUN   TestAccBedrockAgent_serial
=== PAUSE TestAccBedrockAgent_serial
=== CONT  TestAccBedrockAgent_serial
=== RUN   TestAccBedrockAgent_serial/DataSource
=== RUN   TestAccBedrockAgent_serial/DataSource/disappears
=== RUN   TestAccBedrockAgent_serial/DataSource/full
--- PASS: TestAccBedrockAgent_serial (3376.83s)
    --- PASS: TestAccBedrockAgent_serial/DataSource (3376.82s)
        --- PASS: TestAccBedrockAgent_serial/DataSource/disappears (1604.70s)
        --- PASS: TestAccBedrockAgent_serial/DataSource/full (1772.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent	3400.536s
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/bedrockagent/... -v -count 1 -parallel 20  -run=TestAccBedrockAgent_serial/DataSource/update\|TestAccBedrockAgent_serial/DataSource/full -timeout 720m
=== RUN   TestAccBedrockAgent_serial
=== PAUSE TestAccBedrockAgent_serial
=== CONT  TestAccBedrockAgent_serial
=== RUN   TestAccBedrockAgent_serial/DataSource
=== RUN   TestAccBedrockAgent_serial/DataSource/full
=== RUN   TestAccBedrockAgent_serial/DataSource/update
--- PASS: TestAccBedrockAgent_serial (3621.93s)
    --- PASS: TestAccBedrockAgent_serial/DataSource (3621.93s)
        --- PASS: TestAccBedrockAgent_serial/DataSource/full (1737.24s)
        --- PASS: TestAccBedrockAgent_serial/DataSource/update (1884.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent	3632.520s

@ewbankkit
Copy link
Contributor

@markoskandylis Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b427b38 into hashicorp:main May 3, 2024
49 checks passed
@github-actions github-actions bot added this to the v5.49.0 milestone May 3, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 10, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.49.0
Development

Successfully merging this pull request may close these issues.

[New Service]: aws_bedrockagent
3 participants
@markoskandylis @ewbankkit @justinretzolk