Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: Retry interval differences AWS SDK for Go v1 vs. v2 #37392

Closed
ewbankkit opened this issue May 9, 2024 · 3 comments · Fixed by #37404
Closed

provider: Retry interval differences AWS SDK for Go v1 vs. v2 #37392

ewbankkit opened this issue May 9, 2024 · 3 comments · Fixed by #37404
Assignees
Milestone

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented May 9, 2024

With the same MaxBackoff value there are difference in the intervals between AWS API retries once a service has been migrated to AWS SDK for Go v2.

0 v1: 630.788732ms, v2: 945.744952ms
1 v1: 1.968732734s, v2: 1.126478491s
2 v1: 2.20481372s, v2: 2.545221848s
3 v1: 7.532031816s, v2: 635.941503ms
4 v1: 12.045658128s, v2: 11.077754624s
5 v1: 30.031037856s, v2: 5.591619859s
6 v1: 32.040432512s, v2: 1m0.955585351s
7 v1: 1m55.362036224s, v2: 1m19.521948388s
8 v1: 3m38.137199104s, v2: 3m40.088568289s
9 v1: 4m18.424388096s, v2: 5m0s
10 v1: 4m46.703965631s, v2: 5m0s
11 v1: 2m35.866222784s, v2: 5m0s
12 v1: 2m30.149337856s, v2: 5m0s
13 v1: 3m20.359878778s, v2: 5m0s
14 v1: 3m17.264095446s, v2: 5m0s
15 v1: 4m3.904984914s, v2: 5m0s
16 v1: 3m30.635952047s, v2: 5m0s
17 v1: 4m39.437365028s, v2: 5m0s
18 v1: 4m30.536869856s, v2: 5m0s
19 v1: 4m52.61770741s, v2: 5m0s
20 v1: 4m1.91152798s, v2: 5m0s
21 v1: 3m43.366201988s, v2: 5m0s
22 v1: 4m0.243450675s, v2: 5m0s
23 v1: 4m57.797151274s, v2: 5m0s
24 v1: 3m28.727491899s, v2: 5m0s

Relates #36024.
Relates #36837.
Relates #32976.
Relates hashicorp/aws-sdk-go-base#1044.
Requires Requires #37400.

Copy link

github-actions bot commented May 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@ewbankkit ewbankkit changed the title provider: Retry interval differences AWS SDK for GO v1 vs. v2 provider: Retry interval differences AWS SDK for Go v1 vs. v2 May 9, 2024
@ewbankkit ewbankkit self-assigned this May 9, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 9, 2024
Copy link

github-actions bot commented May 9, 2024

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.49.0 milestone May 9, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 10, 2024
Copy link

This functionality has been released in v5.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant