Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_dynamodb_table: Fix UnknownOperationException: Tagging is not currently supported in DynamoDB Local errors on resource Read #37472

Merged
merged 2 commits into from
May 13, 2024
Merged

r/aws_dynamodb_table: Fix UnknownOperationException: Tagging is not currently supported in DynamoDB Local errors on resource Read #37472

merged 2 commits into from
May 13, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented May 13, 2024 •
edited
Loading

Description

Migrates the special tagging interceptor handling of certain DynamoDB errors to AWS SDK for Go v2.

Relations

Closes #37463.
Relates #37288.

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@ewbankkit
r/aws_dynamodb_table: Fix `UnknownOperationException: Tagging is not …
7d7a2b4 
…currently supported in DynamoDB Local` errors on resource Read.
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. labels May 13, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 13, 2024
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. service/dynamodb Issues and PRs that pertain to the dynamodb service. tags Pertains to resource tagging. labels May 13, 2024
johnsonaj
johnsonaj approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit merged commit c12f1a4 into main May 13, 2024
91 checks passed
@ewbankkit ewbankkit deleted the b-aws_dynamodb-table.ListTags.DynamoDB-Local branch May 13, 2024 18:09
@github-actions github-actions bot added this to the v5.50.0 milestone May 13, 2024
This was referenced May 14, 2024
Closed
Merged
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 17, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@agrzegorczyk-leonsoftware agrzegorczyk-leonsoftware mentioned this pull request Jun 11, 2024
Closed
@ewbankkit ewbankkit mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsonaj johnsonaj johnsonaj approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. provider Pertains to the provider itself, rather than any interaction with AWS. service/dynamodb Issues and PRs that pertain to the dynamodb service. size/XS Managed by automation to categorize the size of a PR. tags Pertains to resource tagging.
Projects
None yet
Milestone
v5.50.0
Development

Successfully merging this pull request may close these issues.

[Bug]: 5.49.0 not working with DynamoDB Local
2 participants
@ewbankkit @johnsonaj