Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lakeformation tag value limitation to real in documentation #37638

Merged
merged 1 commit into from
May 23, 2024
Merged

Update lakeformation tag value limitation to real in documentation #37638

merged 1 commit into from
May 23, 2024

Conversation

Udbv
Copy link
Contributor

@Udbv Udbv commented May 22, 2024

Description

The maximum number of values that can be defined for a LF-Tag is 1000.

Relations

Closes #37608

References

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lakeformation_lf_tag

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@Udbv
Update lakeformation tag value limitation
dde626c 
The maximum number of values that can be defined for a LF-Tag is 1000.
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/lakeformation Issues and PRs that pertain to the lakeformation service. labels May 22, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 22, 2024
github-actions[bot]
github-actions bot reviewed May 22, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @Udbv 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@johnsonaj johnsonaj removed the needs-triage Waiting for first response or review from a maintainer. label May 23, 2024
johnsonaj
johnsonaj approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

HAHGX
HAHGX approved these changes May 23, 2024
View reviewed changes
Copy link

@HAHGX HAHGX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your work.

HAHGX
HAHGX approved these changes May 23, 2024
View reviewed changes
Copy link

@HAHGX HAHGX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your work.

@johnsonaj johnsonaj merged commit 13a2d73 into hashicorp:main May 23, 2024
49 checks passed
@github-actions github-actions bot added this to the v5.51.0 milestone May 23, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@HAHGX HAHGX HAHGX approved these changes

@johnsonaj johnsonaj johnsonaj approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/lakeformation Issues and PRs that pertain to the lakeformation service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v5.51.0
Development

Successfully merging this pull request may close these issues.

[Docs]: Incorrect limit for LF-Tags
3 participants
@Udbv @HAHGX @johnsonaj