Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsetting ser_de_info.name from aws_glue_catalog_table results in error #5094

Closed
f0rk opened this issue Jul 5, 2018 · 6 comments · Fixed by #15127
Closed

Unsetting ser_de_info.name from aws_glue_catalog_table results in error #5094

f0rk opened this issue Jul 5, 2018 · 6 comments · Fixed by #15127
Labels
bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service.
Milestone

Comments

@f0rk
Copy link
Contributor

f0rk commented Jul 5, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

Affected Resource(s)

  • aws_glue_catalog_table

Terraform Configuration Files

before:

    ser_de_info {
      name = "OrcSerDe"
      serialization_library = "org.apache.hadoop.hive.ql.io.orc.OrcSerde"
    }

after:

    ser_de_info {
      serialization_library = "org.apache.hadoop.hive.ql.io.orc.OrcSerde"
    }

Debug Output

  storage_descriptor.0.ser_de_info.0.name: "OrcSerDe" => ""
Releasing state lock. This may take a few moments...

Error: Error applying plan:

1 error(s) occurred:

* aws_glue_catalog_table.daily_claims: 1 error(s) occurred:

* aws_glue_catalog_table.daily_claims: Error updating Glue Catalog Table: InvalidParameter: 1 validation error(s) found.
- minimum field size of 1, UpdateTableInput.TableInput.StorageDescriptor.SerdeInfo.Name.

Expected Behavior

name should be deleted.

Actual Behavior

name is set to empty.

@bflad bflad added the service/glue Issues and PRs that pertain to the glue service. label Jul 5, 2018
@rgosh001
Copy link

https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/resource_aws_glue_catalog_table.go#L141

even if i don't add the name, it still says it's required as well. Even though the source code shows it's a optional input parameter

@brandonwbrown
Copy link

is there any harm in adding the name?

@franciscocpg
Copy link

I'm facing the same problem.

The docs (both terraform and AWS) states that it's an optional field.

Why is it validating minimum field size?

@aeschright aeschright added needs-triage Waiting for first response or review from a maintainer. bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 24, 2019
@justinnaldzin
Copy link

is there any harm in adding the name?

You can add a placeholder name of at least one character in your terraform config. But Glue Crawlers will unset/remove the serde name. So every terraform plan will see this as a change. And you can't add the serde name to the lifecycle: ignore_changes block because as mentioned above, the SDK requires it.

@ghost
Copy link

ghost commented Oct 22, 2020

This has been released in version 3.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service.
Projects
None yet
8 participants