Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Kinesis Data Firehose server-side encryption #6443

Closed
ewbankkit opened this issue Nov 13, 2018 · 5 comments · Fixed by #6523
Closed

Feature request: Kinesis Data Firehose server-side encryption #6443

ewbankkit opened this issue Nov 13, 2018 · 5 comments · Fixed by #6523
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service.
Milestone

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Nov 13, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Server-side encryption for Amazon Kinesis Data Firehose recently announced.
Requires:

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service. labels Nov 13, 2018
@ewbankkit
Copy link
Contributor Author

It seems that Kinesis Firehose delivery stream tagging is also enabled with this SDK release.

@ewbankkit
Copy link
Contributor Author

ewbankkit commented Nov 16, 2018

Proposed syntax:

resource "aws_kinesis_firehose_delivery_stream" "test_stream" {
  name                   = "terraform-kinesis-firehose-test-stream"
  destination            = "s3"
  server_side_encryption {
    enabled = true
  }
  ...
}

server_side_encryption conflicts with kinesis_source_configuration is specified as it's the Kinesis data stream's responsibility to enable server-side encryption.

@bflad
Copy link
Contributor

bflad commented Aug 30, 2019

Support for the new server_side_encryption configuration block has been merged and will release with version 2.27.0 of the Terraform AWS Provider, in about a week. 👍 Thanks to @ewbankkit for the implementation.

@ghost
Copy link

ghost commented Sep 5, 2019

This has been released in version 2.27.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants