Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_dynamodb_table: Add missing billing_mode and point_in_time attributes #7496

Closed
ewbankkit opened this issue Feb 10, 2019 · 4 comments · Fixed by #7497
Closed

d/aws_dynamodb_table: Add missing billing_mode and point_in_time attributes #7496

ewbankkit opened this issue Feb 10, 2019 · 4 comments · Fixed by #7497
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/dynamodb Issues and PRs that pertain to the dynamodb service.
Milestone

Comments

@ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

The aws_dynamodb_table data source documentation states

See the DynamoDB Table Resource for details on the returned attributes - they are identical.

However, the billing_mode (added via #6648) and point_in_time_recovery (added via #4063) attributes are missing.

@ewbankkit ewbankkit changed the title d/aws_dynamodb_table: Add missing attributes d/aws_dynamodb_table: Add missing billing_mode and point_in_time attributes Feb 10, 2019
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/dynamodb Issues and PRs that pertain to the dynamodb service. labels Feb 11, 2019
@bflad
Copy link
Contributor

bflad commented Feb 11, 2019

It might be best to remove that verbiage from the data source and copy the resource documentation over instead of incorrectly setting expectations. Sometimes new resource functionality is not as important for the data source, depending on the use case. We've been doing the same in the actual codebase to prevent schema issues from new functionality (explicitly copying the logic) for places where the data source read function used to call the read function of the resource.

We'll probably still pull in something like #7497 since the work is already done though.

@bflad bflad added this to the v1.59.0 milestone Feb 12, 2019
@bflad
Copy link
Contributor

bflad commented Feb 12, 2019

Support for these two attributes has been merged and will release with version 1.59.0 of the Terraform AWS Provider, likely middle of this week. 👍

@bflad
Copy link
Contributor

bflad commented Feb 14, 2019

This has been released in version 1.59.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/dynamodb Issues and PRs that pertain to the dynamodb service.
Projects
None yet
2 participants