Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Add support for LAMBDA in aws_ssm_maintenance_window_task resource #7746

Closed
liamfit opened this issue Feb 27, 2019 · 2 comments · Fixed by #7823
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service.
Milestone

Comments

@liamfit
Copy link

liamfit commented Feb 27, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Similar to #4408
I could do with support for registering a Lambda task with a maintenance window. In fact the current implementation uses

TaskParameters={
        'string': {
            'Values': [
                'string',
            ]
        }
    },

Which has been deprecated in favour of

    TaskInvocationParameters={
        'RunCommand': {
            'Comment': 'string',
            'DocumentHash': 'string',
            'DocumentHashType': 'Sha256'|'Sha1',
            'NotificationConfig': {
                'NotificationArn': 'string',
                'NotificationEvents': [
                    'All'|'InProgress'|'Success'|'TimedOut'|'Cancelled'|'Failed',
                ],
                'NotificationType': 'Command'|'Invocation'
            },
            'OutputS3BucketName': 'string',
            'OutputS3KeyPrefix': 'string',
            'Parameters': {
                'string': [
                    'string',
                ]
            },
            'ServiceRoleArn': 'string',
            'TimeoutSeconds': 123
        },
        'Automation': {
            'DocumentVersion': 'string',
            'Parameters': {
                'string': [
                    'string',
                ]
            }
        },
        'StepFunctions': {
            'Input': 'string',
            'Name': 'string'
        },
        'Lambda': {
            'ClientContext': 'string',
            'Qualifier': 'string',
            'Payload': b'bytes'
        }
    },

Implementing this would provide support for all 4 types of task

New or Affected Resource(s)

  • resource_aws_ssm_maintenance_window_task.go

References

https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ssm.html#SSM.Client.register_task_with_maintenance_window

@liamfit liamfit added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 27, 2019
@bflad bflad added the service/ssm Issues and PRs that pertain to the ssm service. label Apr 11, 2019
@bflad bflad added this to the v2.20.0 milestone Jul 16, 2019
@bflad
Copy link
Contributor

bflad commented Jul 16, 2019

Support for a new task_invocation_parameters configuration block in the aws_ssm_maintenance_window_task resource has been merged and will release with version 2.20.0 of the Terraform AWS Provider, expected later this week. Thanks to @kterada0509 for the implementation work. 👍

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants