Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tags in aws_service_discovery_private_dns_namespace #7840

Closed
barnharts4 opened this issue Mar 6, 2019 · 5 comments
Closed

Support tags in aws_service_discovery_private_dns_namespace #7840

barnharts4 opened this issue Mar 6, 2019 · 5 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. stale Old or inactive issues managed by automation, if no further action taken these will get closed. upstream Addresses functionality related to the cloud provider.

Comments

@barnharts4
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

aws_service_discovery_private_dns_namespace does not support adding tags. However, it creates a Route53 hosted zone, which costs money monthly. Since we use tags to track and allocate costs, we have no way to have this resource's hosted zone reflected in our cost reporting by tag.

Please add support for adding a tags collection to this resource which will propagate to all underlying AWS resources that support tags.

New or Affected Resource(s)

  • aws_service_discovery_private_dns_namespace

Potential Terraform Configuration

  resource "aws_service_discovery_private_dns_namespace" "mytest" {
    name = "mytestzone.lcl"
    vpc  = "${var.vpc_id}"
  }

References

@barnharts4 barnharts4 added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 6, 2019
@barnharts4 barnharts4 changed the title Support tags in aws_service_discovery_private_dns_namespace Support tags in aws_service_discovery_private_dns_namespace Mar 6, 2019
@bflad bflad added the service/servicediscovery Issues and PRs that pertain to the servicediscovery service. label Mar 6, 2019
@bflad
Copy link
Member

bflad commented Mar 6, 2019

Hi @barnharts4 👋 It does not appear that Cloud Map currently supports this functionality in its API, which means support within the Terraform AWS Provider is not likely to be implemented at the current time due to its potential maintenance burden. I would suggest reaching out to AWS through your Support or TAM channels to request this functionality and we will be happy to include it if/when its natively supported by the API.

@bflad bflad added the upstream Addresses functionality related to the cloud provider. label Mar 6, 2019
@ewbankkit
Copy link
Contributor

ewbankkit commented Jun 14, 2020

@github-actions
Copy link

github-actions bot commented Jun 5, 2022

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Jun 5, 2022
@ewbankkit
Copy link
Contributor

tags are now supported on the aws_service_discovery_private_dns_namespace resource.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. stale Old or inactive issues managed by automation, if no further action taken these will get closed. upstream Addresses functionality related to the cloud provider.
Projects
None yet
Development

No branches or pull requests

3 participants