Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AcceptTransitGatewayVpcAttachment API call #8125

Closed
ghost opened this issue Mar 29, 2019 · 5 comments · Fixed by #8679
Closed

Implement AcceptTransitGatewayVpcAttachment API call #8125

ghost opened this issue Mar 29, 2019 · 5 comments · Fixed by #8679
Labels
new-resource Introduces a new resource. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@ghost
Copy link

ghost commented Mar 29, 2019

This issue was originally opened by @KundK as hashicorp/terraform#20869. It was migrated here as a result of the provider split. The original body of the issue is below.


Current Terraform Version

Terraform 0.11.10
AWS provider 2.4.0

Use-cases

When creating a aws_ec2_transit_gateway_vpc_attachment with a shared TGW from another account the attachment goes into 'pendingAcceptance ' state.
It has to be accepted manually on the console or by the AcceptTransitGatewayVpcAttachment API call.
It seems like that API call doesn't have a provider resource.

Attempted Solutions

Proposal

Create data source and resource similar to 'aws_dx_hosted_public_virtual_interface_accepter'

References

https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_AcceptTransitGatewayVpcAttachment.html

@ewbankkit
Copy link
Contributor

ewbankkit commented May 12, 2019

For acceptance testing this depends on #7601, #8259 as the transit gateway must be shared to and accepted in the account to which the transit gateway VPC attachment will be made and accepted.

@ewbankkit
Copy link
Contributor

Suggested syntax for a new aws_ec2_transit_gateway_vpc_attachment_accepter resource (modeled on aws_vpc_peering_connection_accepter):

# Creator
resource "aws_ec2_transit_gateway_vpc_attachment" "example" {
...
}

# Accepter
resource "aws_ec2_transit_gateway_vpc_attachment_accepter" "example" {
  provider = "aws.alternate"

  transit_gateway_attachment_id = "${aws_ec2_transit_gateway_vpc_attachment.example.id}"
}

The exported attributes would be the attributes of the aws_ec2_transit_gateway_vpc_attachment resource:

  • transit_gateway_id
  • vpc_id
  • vpc_owner_id
  • subnet_ids
  • dns_support
  • ipv6_support

@bflad bflad added new-resource Introduces a new resource. service/ec2 Issues and PRs that pertain to the ec2 service. labels May 27, 2019
@bflad bflad added this to the v2.13.0 milestone May 27, 2019
@bflad
Copy link
Contributor

bflad commented May 27, 2019

Hi folks 👋 A new aws_ec2_transit_gateway_vpc_attachment_accepter resource has been merged and will release with version 2.13.0 of the Terraform AWS Provider, likely later this week. 👍

@bflad
Copy link
Contributor

bflad commented May 31, 2019

This has been released in version 2.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link
Author

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants