Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for postgresql enabled_cloudwatch_logs_exports to aws_rds_cluster #9669

Closed
ckuehl opened this issue Aug 7, 2019 · 3 comments · Fixed by #9740
Closed

Add support for postgresql enabled_cloudwatch_logs_exports to aws_rds_cluster #9669

ckuehl opened this issue Aug 7, 2019 · 3 comments · Fixed by #9740
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Milestone

Comments

@ckuehl
Copy link

ckuehl commented Aug 7, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

v0.12

Affected Resource(s)

  • aws_rds_cluster

Details

Aurora Postgres now supports exporting postgresql logs to CloudWatch:

        {
            "Engine": "aurora-postgresql",
            "EngineVersion": "10.7",
            "DBParameterGroupFamily": "aurora-postgresql10",
            "DBEngineDescription": "Aurora (PostgreSQL)",
            "DBEngineVersionDescription": "Aurora PostgreSQL (compatible with PostgreSQL 10.7)",
            "ValidUpgradeTarget": [],
            "ExportableLogTypes": [
                "postgresql"
            ],
            "SupportsLogExportsToCloudwatchLogs": true,
            "SupportsReadReplica": false,
            "SupportedEngineModes": [
                "provisioned"
            ],
            "SupportedFeatureNames": [
                "s3Import"
            ]
        }

Attempting to set the value currently generates this error:

Error: expected enabled_cloudwatch_logs_exports.0 to be one of [audit error general slowquery], got postgresql

This needs to be updated to support postgresql as a valid value.

References

@ghost ghost added the service/rds Issues and PRs that pertain to the rds service. label Aug 7, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 7, 2019
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 14, 2019
@bflad bflad modified the milestones: v2.24.0, v2.25.0 Aug 14, 2019
@bflad
Copy link
Contributor

bflad commented Aug 15, 2019

Support for the postgresql value has been merged and will release with version 2.25.0 of the Terraform AWS Provider, in about a week. Thanks to @ste1nstone for the implementation. 👍

@ghost
Copy link

ghost commented Aug 23, 2019

This has been released in version 2.25.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants