Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Sets #39

Closed
ewbankkit opened this issue Jul 14, 2021 · 3 comments · Fixed by #158
Closed

Support Sets #39

ewbankkit opened this issue Jul 14, 2021 · 3 comments · Fixed by #158
Assignees
@ewbankkit
Labels
code-generation Relates to the conversion of CloudFormation schema to Terraform schema at buildtime. upstream-plugin-framework Unable to proceed due to missing or broken functionality from terraform-plugin-framework
Milestone
v0.1.0

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Jul 14, 2021 •
edited by breathingdust
Loading

Description

Relates hashicorp/terraform-plugin-framework#53.
As of v0.1.0 terraform-plugin-framework does not support Terraform Sets.
This limits the resource schemas that can be generated.
Once upstream support is added, enhance this provider.

Definition of Done
@ewbankkit
Copy link
Contributor Author

We can implement our own custom Set type if this is a blocker (which it is right now).

This was referenced Jul 20, 2021
Closed
Closed
@breathingdust breathingdust added the upstream-plugin-framework Unable to proceed due to missing or broken functionality from terraform-plugin-framework label Jul 28, 2021
@breathingdust breathingdust added this to the v0.2.0 milestone Jul 28, 2021
@breathingdust breathingdust added the code-generation Relates to the conversion of CloudFormation schema to Terraform schema at buildtime. label Jul 28, 2021
@breathingdust
Copy link
Member

Upstream support in the terraform-plugin-framework is likely to arrive within the next four weeks.

@ewbankkit
Copy link
Contributor Author

Open Question

Are Terraform sets ordered or not?
The CloudFormation Resource Schema definition has two elements which describe how arrays should be handled, insertionOrder and uniqueItems. See here for how the combinations map to programming language types.
Currently we are mapping what AWS call set and ordered set (e.g. for ECS Task Definition ContainerDefinitions) to Terraform sets - Is this correct?

This was referenced Aug 10, 2021
Closed
Closed
Closed
@ewbankkit ewbankkit self-assigned this Sep 15, 2021
@ewbankkit ewbankkit mentioned this issue Sep 15, 2021
Merged
@breathingdust breathingdust modified the milestones: v0.2.0, v0.1.0 Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ewbankkit ewbankkit

Labels
code-generation Relates to the conversion of CloudFormation schema to Terraform schema at buildtime. upstream-plugin-framework Unable to proceed due to missing or broken functionality from terraform-plugin-framework
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

Use plugin-framework type.Set implementation hashicorp/terraform-provider-awscc
2 participants
@breathingdust @ewbankkit