Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_named_location: validation for ip_ranges property #1254

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

manicminer
Copy link
Member

@manicminer manicminer commented Nov 16, 2023

From the docs:

Screenshot 2023-11-16 at 15 12 32

closes #855

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@manicminer
Copy link
Member Author

Test results

Screenshot 2023-11-16 at 22 57 43

@manicminer manicminer merged commit 1734531 into main Nov 16, 2023
18 checks passed
@manicminer manicminer deleted the f/ip-prefix-validation branch November 16, 2023 22:58
manicminer added a commit that referenced this pull request Nov 16, 2023
dduportal added a commit to jenkins-infra/azure that referenced this pull request Nov 17, 2023
<Actions>
<action
id="6d17e7acdb2f3311576150379e22805f2f9b4aa72ff00ec136aceee45cae4b98">
        <h3>Bump Terraform `azuread` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>&#34;hashicorp/azuread&#34; updated from &#34;2.45.0&#34; to
&#34;2.46.0&#34; in file &#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>2.46.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azuread/releases/tag/v2.46.0&#xA;ENHANCEMENTS:&#xA;&#xA;*
`data.azuread_application` - update the resource ID format to match the
`azuread_application` resource
([#1255](https://github.com/hashicorp/terraform-provider-azuread/issues/1255))&#xA;*
`azuread_named_location` - add validation for the `ip_ranges` property
in the `ip` block
([#1254](https://github.com/hashicorp/terraform-provider-azuread/issues/1254))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[azuread_named_location] Lack of validation on CIDR masks in ip_ranges parameter
2 participants