Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add group writeback functionality #964

Merged
merged 15 commits into from
Apr 13, 2023
Merged

Conversation

tomasmota
Copy link
Contributor

Fixes #934

Depends on manicminer/hamilton#199

@manicminer
Copy link
Member

@tomasmota I'm keen to get this merged, but I am having issues whilst testing. After enabling writeback for a group, it starts to misbehave and certain requests to GET or PATCH the group start to return a 404 or 403. It seems to be reproducible but I am not sure whether it's something we're doing wrong or whether the API is misbehaving.

I'll dig more into this next week, but for now I have pushed some changes including some docs fixups and bumping Hamilton to pull in the casing fixes.

@tomasmota
Copy link
Contributor Author

tomasmota commented Jan 12, 2023

Thanks for testing this out. Have you managed to reproduce it just using hamilton?

@tomasmota
Copy link
Contributor Author

Let me know if there is anything I can do to help troubleshooting this @manicminer

@manicminer
Copy link
Member

@tomasmota Thanks, at this time I am still having issues whilst testing. I'll have to unfortunately bump to next week but will spend time digging deeper in the meantime.

@manicminer manicminer modified the milestones: v2.33.0, v2.34.0 Jan 18, 2023
@hashicorp hashicorp deleted a comment from github-actions bot Jan 19, 2023
@manicminer manicminer modified the milestones: v2.34.0, v2.35.0 Feb 16, 2023
@manicminer manicminer modified the milestones: v2.35.0, v2.36.0 Feb 23, 2023
@manicminer manicminer modified the milestones: v2.36.0, v2.37.0 Mar 2, 2023
Signed-off-by: Thomas Mota <tmm@danskecommodities.com>
Signed-off-by: Thomas Mota <tmm@danskecommodities.com>
Signed-off-by: Thomas Mota <tmm@danskecommodities.com>
Signed-off-by: Thomas Mota <tmm@danskecommodities.com>
Signed-off-by: Thomas Mota <tmm@danskecommodities.com>
tomasmota and others added 10 commits April 13, 2023 20:57
Signed-off-by: Thomas Mota <tmm@danskecommodities.com>
Signed-off-by: Thomas Mota <tmm@danskecommodities.com>
Signed-off-by: Thomas Mota <tmm@danskecommodities.com>
Signed-off-by: Thomas Mota <tmm@danskecommodities.com>
Signed-off-by: Thomas Mota <tmm@danskecommodities.com>
Signed-off-by: Tomás Mota <tmm@danskecommodities.com>
Copy link
Member

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomasmota Good news, the earlier issues with spontaneous 40x responses seem to be resolved. After rebasing and tweaking the schema, this is working great. Thanks again for working on this 👍

@manicminer
Copy link
Member

Test results

Screenshot 2023-04-13 at 21 38 47

@manicminer manicminer merged commit 6bc531d into hashicorp:main Apr 13, 2023
7 checks passed
manicminer added a commit that referenced this pull request Apr 13, 2023
@github-actions
Copy link

This functionality has been released in v2.37.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to set "Writeback enabled" on azuread_group resources
2 participants