Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade load balancer API to 2020-05-01 #10263

Merged

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Jan 21, 2021

Fix #7691 (although it is closed, as we downgraded the api version to 03-01)

Test

💤 make testacc TEST=./azurerm/internal/services/loadbalancer TESTARGS='-run TestAccAzureRMLoadBalancerRule_vmssBackendPoolUpdateRemoveLBRule'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/loadbalancer -v -run TestAccAzureRMLoadBalancerRule_vmssBackendPoolUpdateRemoveLBRule -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMLoadBalancerRule_vmssBackendPoolUpdateRemoveLBRule
=== PAUSE TestAccAzureRMLoadBalancerRule_vmssBackendPoolUpdateRemoveLBRule
=== CONT  TestAccAzureRMLoadBalancerRule_vmssBackendPoolUpdateRemoveLBRule
--- PASS: TestAccAzureRMLoadBalancerRule_vmssBackendPoolUpdateRemoveLBRule (602.06s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/loadbalancer        602.100s

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment but this otherwise LGTM 👍

@magodo
Copy link
Collaborator Author

magodo commented Jan 22, 2021

@tombuildsstuff Done.

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Member

Tests pass:

Screenshot 2021-01-22 at 12 19 29

@tombuildsstuff tombuildsstuff merged commit 5ae74e9 into hashicorp:master Jan 22, 2021
tombuildsstuff added a commit that referenced this pull request Jan 22, 2021
@ghost
Copy link

ghost commented Jan 28, 2021

This has been released in version 2.45.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.45.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 21, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.18.0 - Error removing/updating load balancer rules
2 participants