keyvault: normalizing the casing of the permissions #10593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azure's now returning casing which differs from the SDK - as such we need to normalize these on our side. Fixes #10591
tombuildsstuff
added
bug
service/key-vault
ghost
added
|
Tests look good 👍 |
|
This has been released in version 2.48.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.48.0"
}
# ... other configuration ... |
Shr3ps
added a commit
to claranet/terraform-azurerm-keyvault
that referenced
this pull request
Mar 9, 2021
Changed * AZ-458: normalizing the casing of the permissions to comply with provider changes hashicorp/terraform-provider-azurerm#10593
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR normalizes the casing on the Permissions keys within the
azurerm_key_vaultandazurerm_key_vault_access_policyresources - due to the casing being returned from the API, and the casing on the Constants in the SDK differing. This also adds a DiffSuppressFunc to the Storage Permissions field - to allow for this to happen without diff's, which can ultimately be removed in 3.0 (across all of these) and made case-sensitive, since we're normalizing these casings on Terraform's side.Fixes #10591