Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/frontdoor: removing the MaxItems validation from the Backend Pools #10828

Merged
merged 1 commit into from Mar 4, 2021

Conversation

tombuildsstuff
Copy link
Member

Azure Support allows overriding the maximum value, so this is best-effort

Supersedes #10801
Fixes #10800

Azure Support allows overriding the maximum value, so this is best-effort

Fixes #10800
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still believe we should still have a check for the upper bound limit, however unblocking our customers is the most important thing here.

@WodansSon
Copy link
Collaborator

Tests passed with one expected failure due to known order issue...
image

@WodansSon WodansSon merged commit 730cc47 into master Mar 4, 2021
@WodansSon WodansSon deleted the b/frontdoor-validation branch March 4, 2021 20:49
WodansSon added a commit that referenced this pull request Mar 4, 2021
@ghost
Copy link

ghost commented Mar 5, 2021

This has been released in version 2.50.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.50.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 4, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_frontdoor: Expose a way to bypass backend_pool max backend_pool count.
2 participants