Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: removing checking of futures during deletion #12879

Merged
merged 2 commits into from Aug 10, 2021
Merged

bug: removing checking of futures during deletion #12879

merged 2 commits into from Aug 10, 2021

Conversation

tombuildsstuff
Copy link
Member

@tombuildsstuff tombuildsstuff commented Aug 6, 2021 •
edited

These exist for users who are running terraform destroy without a refresh, but that behaviour isn't intentionally supported (we explicitly recommend users run a refresh/plan before any change); as such removing these isn't considered a breaking change and works around an issue in the Azure SDK

Fixes #12852

@tombuildsstuff tombuildsstuff added this to the v2.72.0 milestone Aug 6, 2021
@tombuildsstuff tombuildsstuff requested a review from a team August 6, 2021 14:46
@tombuildsstuff tombuildsstuff force-pushed the b/removing-futures-in-deletes branch 2 times, most recently from f2a3272 to 23ac7d3 Compare August 9, 2021 09:02
@tombuildsstuff tombuildsstuff mentioned this pull request Aug 10, 2021
Merged
@tombuildsstuff
bug: removing checking of futures during deletion
813ddf3 
These exist for users who are running `terraform destroy` without a refresh, but that behaviour isn't
intentionally supported (we explicitly recommend users run a refresh/plan before any change); as such
removing these isn't considered a breaking change.
jackofallops
jackofallops approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tombuildsstuff - just a few minor observations, but otherwise LGTM 👍

internal/services/containers/container_registry_resource.go Outdated Show resolved Hide resolved
internal/services/eventgrid/eventgrid_domain_topic_resource.go Outdated Show resolved Hide resolved
internal/services/frontdoor/frontdoor_resource.go Outdated Show resolved Hide resolved
@tombuildsstuff @jackofallops
Apply suggestions from code review
afccc72 
Co-authored-by: Steve <11830746+jackofallops@users.noreply.github.com>
@tombuildsstuff tombuildsstuff merged commit 480200d into main Aug 10, 2021
@tombuildsstuff tombuildsstuff deleted the b/removing-futures-in-deletes branch August 10, 2021 08:54
tombuildsstuff added a commit that referenced this pull request Aug 10, 2021
@tombuildsstuff
updating to include #12879
964ecbc
tombuildsstuff added a commit that referenced this pull request Aug 10, 2021
@tombuildsstuff
updating to include #12879
9649b8b
@github-actions
Copy link

This functionality has been released in v2.72.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops approved these changes

Assignees
No one assigned
Labels
bug size/XL
Projects
None yet
Milestone
v2.72.0
Development

Successfully merging this pull request may close these issues.

Provider crash on frontdoor destruction
2 participants
@tombuildsstuff @jackofallops