Add Azure Video Analyzer Edge Module resource #12911
Conversation
There was a problem hiding this comment.
hey @EliiseS
Thanks for this PR - taking a look through I've left a couple of minor comments inline but this otherwise LGTM 👍
Thanks!
internal/services/videoanalyzer/video_analyzer_edge_module_resource.go
Outdated
Show resolved
Hide resolved
|
@tombuildsstuff Addressed the changes, thanks for the feedback! |
| data.ResourceTest(t, r, []acceptance.TestStep{ | ||
| { | ||
| Config: r.basic(data), | ||
| Check: acceptance.ComposeAggregateTestCheckFunc(), |
There was a problem hiding this comment.
can we make this:
| Check: acceptance.ComposeAggregateTestCheckFunc(), | |
| Check: acceptance.ComposeAggregateTestCheckFunc( | |
| check.That(data.ResourceName).ExistsInAzure(r), | |
| ), |
There was a problem hiding this comment.
I've made this into a check of the video_analyzer_name name now
There was a problem hiding this comment.
the values of the video_analyzer_name field are checked in the import below (which validates we can import this from the API) - so it'd be better to check the resource exists in the Azure API (e.g. to check we're not tracking a resource which has been provisioned with the wrong name or something) than the specific value here:
| Check: acceptance.ComposeAggregateTestCheckFunc(), | |
| Check: acceptance.ComposeAggregateTestCheckFunc( | |
| check.That(data.ResourceName).ExistsInAzure(r), | |
| ), |
internal/services/videoanalyzer/video_analyzer_edge_module_resource_test.go
Outdated
Show resolved
Hide resolved
|
@tombuildsstuff Done and done 😄 |
|
Tests pass"
|
|
This functionality has been released in v2.72.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Add support for the Azure Video Analyzer Edge Module described at #12912
Closes #12912