Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_static_site - identity supports SystemAssigned, UserAssigned #15834

Merged
merged 3 commits into from
Mar 18, 2022

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Mar 15, 2022

Fix #15794

Test

💢  TF_ACC=1 go test -v -timeout=20h ./internal/services/web  -run='TestAccAzureStaticSite_with|TestAccAzureStaticSite_identity'
=== RUN   TestAccAzureStaticSite_withSystemAssignedIdentity
=== PAUSE TestAccAzureStaticSite_withSystemAssignedIdentity
=== RUN   TestAccAzureStaticSite_identity
=== PAUSE TestAccAzureStaticSite_identity
=== RUN   TestAccAzureStaticSite_withSystemAssignedUserAssignedIdentity
=== PAUSE TestAccAzureStaticSite_withSystemAssignedUserAssignedIdentity
=== RUN   TestAccAzureStaticSite_withUserAssignedIdentity
=== PAUSE TestAccAzureStaticSite_withUserAssignedIdentity
=== CONT  TestAccAzureStaticSite_withSystemAssignedIdentity
=== CONT  TestAccAzureStaticSite_withSystemAssignedUserAssignedIdentity
=== CONT  TestAccAzureStaticSite_identity
=== CONT  TestAccAzureStaticSite_withUserAssignedIdentity
--- PASS: TestAccAzureStaticSite_withSystemAssignedUserAssignedIdentity (131.75s)
--- PASS: TestAccAzureStaticSite_withSystemAssignedIdentity (182.29s)
--- PASS: TestAccAzureStaticSite_identity (227.74s)
--- PASS: TestAccAzureStaticSite_withUserAssignedIdentity (807.10s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/web   807.112s

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments but if we can fix those up then this should otherwise be good to go 👍

internal/services/web/static_site_resource_test.go Outdated Show resolved Hide resolved
@magodo
Copy link
Collaborator Author

magodo commented Mar 17, 2022

@tombuildsstuff I've updated the test and passed it, please take another look, thank you!

Test

💤  TF_ACC=1 go test -v -timeout=20h ./internal/services/web  -run='TestAccAzureStaticSite_identity$'
=== RUN   TestAccAzureStaticSite_identity
=== PAUSE TestAccAzureStaticSite_identity
=== CONT  TestAccAzureStaticSite_identity
--- PASS: TestAccAzureStaticSite_identity (873.12s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/web   873.134s

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v3.0.0 milestone Mar 18, 2022
@tombuildsstuff tombuildsstuff merged commit 317386f into hashicorp:main Mar 18, 2022
tombuildsstuff added a commit that referenced this pull request Mar 18, 2022
@github-actions
Copy link

This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for both UserAssigned and SystemAssigned for Static Sites
2 participants