Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_application_insights - Remove disable logic for the Azure created Action Group #16170

Merged
merged 2 commits into from
Mar 31, 2022

Conversation

mbfrahry
Copy link
Member

Fixes #16124

Context: #10563 and #15892

The Action Group can take more than an hour to show up and disabling it doesn't provide much value since it's the Rule triggering the Action Group that caused #10563. Just disabling the Rule should be sufficient for #10563

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbfrahry - LGTM 👍

@mbfrahry mbfrahry merged commit 4b0a0b8 into main Mar 31, 2022
@mbfrahry mbfrahry deleted the b-application-insights-action-group branch March 31, 2022 16:28
mbfrahry added a commit that referenced this pull request Mar 31, 2022
@github-actions github-actions bot added this to the v3.1.0 milestone Mar 31, 2022
catriona-m pushed a commit that referenced this pull request Apr 6, 2022
catriona-m pushed a commit that referenced this pull request Apr 6, 2022
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

This functionality has been released in v3.1.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/azurerm_application_insights - provider feature disable_generated_rule isn't working
2 participants