Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_key_vault: fix enabling "purge_protection_enabledissue" does not work issue #16368

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

sinbai
Copy link
Contributor

@sinbai sinbai commented Apr 13, 2022

Fix issue #16289.

When the KV was created with a version prior to v2.42 and the soft_delete_enabled is set to false, setting purge_protection_enabled to true would not work when updating KV with v2.42 or later of terraform provider. This is because the purge_protection_enabled only works when soft delete is enabled. Since version v2.42 of the Azure Provider and later force the value of soft_delete_enabled to be true, we should set EnableSoftDelete to true in func resourceKeyVaultUpdate when purge_protection_enabled is enabled.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v3.12.0 milestone Jun 29, 2022
@tombuildsstuff tombuildsstuff merged commit eef4f04 into hashicorp:main Jun 29, 2022
tombuildsstuff added a commit that referenced this pull request Jun 29, 2022
@sinbai sinbai deleted the keyvault/fix_issue_16289 branch June 30, 2022 01:03
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

This functionality has been released in v3.12.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants