Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppService - fix bug in flattening ip_restriction shared code #16426

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

jackofallops
Copy link
Member

@jackofallops jackofallops commented Apr 18, 2022

  • azurerm_linux_function_app - fix ip_address being incorrectly set into state when service_tag setting specified.
  • azurerm_linux_function_app_slot - fix ip_address being incorrectly set into state when service_tag setting specified.
  • azurerm_windows_function_app - fix ip_address being incorrectly set into state when service_tag setting specified.
  • azurerm_windows_function_app_slot - fix ip_address being incorrectly set into state when service_tag setting specified.
  • azurerm_linux_web_app - fix ip_address being incorrectly set into state when service_tag setting specified.
  • azurerm_linux_web_app_slot - fix ip_address being incorrectly set into state when service_tag setting specified.
  • azurerm_windows_web_app - fix ip_address being incorrectly set into state when service_tag setting specified.
  • azurerm_windows_web_app_slot - fix ip_address being incorrectly set into state when service_tag setting specified.

fixes #16397
fixes #16109

@jackofallops jackofallops added this to the v3.3.0 milestone Apr 18, 2022
@jackofallops jackofallops requested a review from a team April 18, 2022 05:37
@jackofallops jackofallops self-assigned this Apr 18, 2022
Copy link
Member

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍐

@jackofallops jackofallops merged commit 4bbc17e into main Apr 20, 2022
@jackofallops jackofallops deleted the b/function-apps-iprestrictions-servicetags branch April 20, 2022 09:38
jackofallops added a commit that referenced this pull request Apr 20, 2022
@github-actions
Copy link

This functionality has been released in v3.3.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants