azurerm_[windows|linux]_function_app - refactor app_settings processing for updates

[jackofallops]

• azurerm_linux_function_app - fix updates to app_settings
• azurerm_windows_function_app - fix updates to app_settings

fixes #16244
fixes #16396

[sebader]

will this also fix #16396 ?

[jackofallops]

will this also fix #16396 ?

Hi @sebader - I believe it will, yes. Thanks for the heads up, I'll link these together.

[manicminer]

LGTM 🧨

[sebader]

@jackofallops glad to hear it!
What about the WEBSITE_RUN_FROM_PACAKGE setting? I don't see a mention of this in your code changes. Will this stay untouched as it was in the previous version of the Function app resource?

[jackofallops]

@jackofallops glad to hear it! What about the WEBSITE_RUN_FROM_PACAKGE setting? I don't see a mention of this in your code changes. Will this stay untouched as it was in the previous version of the Function app resource?

Hi @sebader - That's a user specified attribute relating to deployments, so won't get an explicit mention in code. Since the app_settings map is multi-purpose, the provider only attempts to manage items in the map that are injected into is as a result of property values "elsewhere" such as storage, or values that are needed to help maintain state/dependency evaluation for Terraform. The specific problem here was that we were not always correctly maintaining existing settings depending on the update scenario / route taken. This should now be resolved, and I've added more test cases we had not previously considered. If you find that there are still issues with this fix in place, I'm happy to re-open the related issue to investigate further.

Thanks!

[github-actions]

This functionality has been released in v3.3.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[sebader]

@jackofallops I just tested 3.3.0:

so the application_stack is not properly kept in place :) However, WEBSITE_RUN_FROM_PACAKGE still gets removed which does break the deployed Function app until you redeploy again. When looking at the old azurerm_function_app resource, it explicitly mentioned this:

This behavior seems to be missing from the new resources

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.