azurerm_vpn_gateway_nat_rule - support for port_range
#16724
Conversation
There was a problem hiding this comment.
Hey @neil-yechenwei, this is nearly there. Just a couple tweaks and it's good
| Type: pluginsdk.TypeList, | ||
| Optional: true, | ||
| Computed: !features.FourPointOhBeta(), | ||
| AtLeastOneOf: func() []string { |
There was a problem hiding this comment.
All of AtLeastOneOf should be swapped to ExactlyOneOf since it's required and we don't want someone to put both external_address_space_mappings and external_mapping in
| @@ -58,16 +64,40 @@ The following arguments are supported: | |||
|
|
|||
| * `vpn_gateway_id` - (Required) The ID of the VPN Gateway that this VPN Gateway NAT Rule belongs to. Changing this forces a new resource to be created. | |||
|
|
|||
| * `external_address_space_mappings` - (Required) A list of CIDR Ranges which are used for external mapping of the VPN Gateway NAT Rule. | |||
| * `external_address_space_mappings` - (Optional) A list of CIDR Ranges which are used for external mapping of the VPN Gateway NAT Rule. | |||
There was a problem hiding this comment.
| * `external_address_space_mappings` - (Optional) A list of CIDR Ranges which are used for external mapping of the VPN Gateway NAT Rule. | |
| * `external_address_space_mappings` - (Deprecated) A list of CIDR Ranges which are used for external mapping of the VPN Gateway NAT Rule. |
There was a problem hiding this comment.
Let's also move external_address_space_mappings and internal_address_space_mappings to the bottom to get them out of view.
|
|
||
| ~> **NOTE:** `external_address_space_mappings` is deprecated and will be removed in favour of the property `external_mapping` in version 4.0 of the AzureRM Provider. | ||
|
|
||
| * `external_mapping` - (Optional) One or more `external_mapping` blocks as documented below. |
There was a problem hiding this comment.
Let's move external_mapping and internal_mapping up and make them required as we want those to be what people use going forward.
|
|
||
| * `internal_address_space_mappings` - (Required) A list of CIDR Ranges which are used for internal mapping of the VPN Gateway NAT Rule. | ||
| * `internal_address_space_mappings` - (Optional) A list of CIDR Ranges which are used for internal mapping of the VPN Gateway NAT Rule. |
There was a problem hiding this comment.
| * `internal_address_space_mappings` - (Optional) A list of CIDR Ranges which are used for internal mapping of the VPN Gateway NAT Rule. | |
| * `internal_address_space_mappings` - (Deprecated) A list of CIDR Ranges which are used for internal mapping of the VPN Gateway NAT Rule. |
|
@mbfrahry , thanks for your comments. I've updated code. Please take another look. Thanks in advance. |
mbfrahry
changed the title
azurerm_vpn_gateway_nat_rule - support for port_range
|
This functionality has been released in v3.9.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR is to support new property
port_rangefor azurerm_vpn_gateway_nat_rule.--- PASS: TestAccVpnGatewayNatRule_basic (4465.47s)
--- PASS: TestAccVpnGatewayNatRule_complete (4610.49s)
--- PASS: TestAccVpnGatewayNatRule_update (4727.26s)
--- PASS: TestAccVpnGatewayNatRule_externalMappingAndInternalMapping (4739.50s)
--- PASS: TestAccVpnGatewayNatRule_requiresImport (4805.02s)