azurerm_container_registry_task - Fix missing authentication when updating

[magodo]

Fix #16959

The source_trigger.authentication is not returned in the GET response. When there is an update to other attributes other than source_trigger, as we conditionally expand source_trigger (only when it HasChanged), the content of source_trigger was from the GET response, therefore missing the source_trigger.authentication. API then complains.

This PR adds a special patch to the source_trigger.authentication in this case, right after the conditional expansion.

Test

❯ TF_ACC=1 go test -timeout=60m -v -run='TestAccContainerRegistryTask_dockerStepSourceTrigger' ./internal/services/containers
=== RUN   TestAccContainerRegistryTask_dockerStepSourceTrigger                                                                                                                              === PAUSE TestAccContainerRegistryTask_dockerStepSourceTrigger
=== CONT  TestAccContainerRegistryTask_dockerStepSourceTrigger
--- PASS: TestAccContainerRegistryTask_dockerStepSourceTrigger (236.26s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/containers    236.271s

[tombuildsstuff]

One comment about readability but this otherwise LGTM 👍

[magodo]

@tombuildsstuff Thank you for the comment! I've refine it and please take another look!

[tombuildsstuff]

If we de-reference this prior to passing this in, we remove doing that from within the method, which removes some of the complexity/potential bugs fwiw - but this otherwise LGTM 👍

[github-actions]

This functionality has been released in v3.9.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.