Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated ioutil pkg with os & io #17392

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

abhinavnair
Copy link
Contributor

As of Go 1.16, the same functionality is now provided by package io or
package os, and those implementations should be preferred in new code.

So replacing all usage of ioutil pkg with io & os.

Do note that the switch from ioutil.TempFile to os.CreateTemp in the go doc itself (i.e. the former just calls the later) was only done in Go 1.17, but the functionality of os.CreateTemp was already available in 1.16 and thus is safe for use with Go 1.16 as well.

As of Go 1.16, the same functionality is now provided by package io or
package os, and those implementations should be preferred in new code.

So replacing all usage of ioutil pkg with io & os.
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @abhinavnair

@tombuildsstuff tombuildsstuff added this to the v3.12.0 milestone Jun 27, 2022
@tombuildsstuff tombuildsstuff merged commit 4a00d21 into hashicorp:main Jun 27, 2022
tombuildsstuff added a commit that referenced this pull request Jun 27, 2022
@abhinavnair abhinavnair deleted the replace-ioutil branch June 27, 2022 07:30
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

This functionality has been released in v3.12.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

sergelogvinov pushed a commit to sergelogvinov/terraform-provider-azurerm that referenced this pull request Jul 11, 2022
@github-actions
Copy link

github-actions bot commented Aug 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants