Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eventhub: refactoring to use go-azure-sdk #17445

Merged
merged 6 commits into from Jul 5, 2022
Merged

eventhub: refactoring to use go-azure-sdk #17445

merged 6 commits into from Jul 5, 2022

Conversation

mbfrahry
Copy link
Member

Lift and shift

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tombuildsstuff
Copy link
Member

@mbfrahry looks like we've got an error here:

panic: interface conversion: interface {} is nil, not *schema.Set
goroutine 389 [running]:
github.com/hashicorp/go-azure-helpers/resourcemanager/identity.ExpandSystemAndUserAssignedMap({0xc002760bf0, 0x1, 0x68a3080?})
  /opt/teamcity-agent/work/5e6516bb4d10eb66/vendor/github.com/hashicorp/go-azure-helpers/resourcemanager/identity/system_and_user_assigned_map.go:69 +0x434
github.com/hashicorp/terraform-provider-azurerm/internal/services/eventhub.resourceEventHubNamespaceCreate(0x0?, {0x5788be0?, 0xc00156ce00})
  /opt/teamcity-agent/work/5e6516bb4d10eb66/internal/services/eventhub/eventhub_namespace_resource.go:276 +0x59c
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).create(0xc001a51b00?, {0x68adc70?, 0xc0022d4e00?}, 0x2?, {0x5788be0?, 0xc00156ce00?})

@mbfrahry mbfrahry added this to the v3.13.0 milestone Jul 5, 2022
@mbfrahry mbfrahry merged commit b129241 into main Jul 5, 2022
@mbfrahry mbfrahry deleted the s-eventhub branch July 5, 2022 23:55
mbfrahry added a commit that referenced this pull request Jul 5, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v3.13.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants