New resource: `azurerm_databricks_access_connector` #18709

favoretti · 2022-10-12T09:13:17Z

Also upgrade Databricks SDK to 2022-04-01-preview

nfx · 2022-10-12T09:19:49Z

Thank you so much, @favoretti !

favoretti · 2022-10-12T13:03:23Z

@tombuildsstuff One catch about this resource. Apparently SPN auth doesn't work with this API, only user-based auth. Wonder what to do about it..

stephybun

Thanks for this @favoretti! Since this is still in private preview I expected the tests to fail when trying to create the connector. Unfortunately it's created the connector in a failed state and currently can't be deleted. I'm going to mark this PR as blocked for the time being while we investigate this further.

Also just as an aside all resources within the provider will eventually need to be converted to typed resources for the gradual shift to using Pandora generated ones. Our contributor docs have a section on how to add new typed resources which will hopefully be helpful for future contributions 🙂.

internal/services/databricks/databricks_access_connector_resource.go

internal/services/databricks/databricks_access_connector_resource_test.go

internal/services/databricks/validate/access_conector_name_test.go

website/docs/r/databricks_access_connector.html.markdown

internal/services/databricks/databricks_access_connector_resource.go

favoretti · 2022-10-12T19:41:40Z

Thanks @stephybun. I completely blacked out on typed resources, I'll rewrite tomorrow, sorry about that.

That failed connector will eventually be deletable. But the real reason it fails is that API doesn't work with SPN auth. I'm working with @nfx and team to see what the ETA is on supporting that.

If persona authentication is used - resource works.

nfx · 2022-10-13T08:09:22Z

@favoretti You say it's the same style of issue as creating the AKV scope for Databricks? 🫣

Also upgrade Databricks SDK to `2022-04-01-preview` I added acceptance tests, but feature is in private preview. Fixes hashicorp#18518

favoretti · 2022-10-13T08:49:21Z

@stephybun rewrote this, SPN thing is still under investigation, but can you please have another look code-wise? Thanks!

favoretti · 2022-10-13T10:53:29Z

@favoretti You say it's the same style of issue as creating the AKV scope for Databricks? 🫣

@nfx Don't think so. AKV scope talks to Databricks DataPlane API, i.e. directly to the instance. This call is directed at management.azure.com, i.e. ARM API. Although you folks would know better, but I think this one should be easier to address.

favoretti · 2022-10-14T06:58:31Z

I hear SPN auth should be fixed. I'll retest today.

favoretti · 2022-10-14T08:21:41Z

Local acceptance tests pass, running TC now.

$ TF_ACC=1 go test -v ./internal/services/databricks -timeout=1000m -run='TestAccDatabricksAccessConnector'
=== RUN   TestAccDatabricksAccessConnector_basic
=== PAUSE TestAccDatabricksAccessConnector_basic
=== RUN   TestAccDatabricksAccessConnector_requiresImport
=== PAUSE TestAccDatabricksAccessConnector_requiresImport
=== CONT  TestAccDatabricksAccessConnector_basic
=== CONT  TestAccDatabricksAccessConnector_requiresImport
--- PASS: TestAccDatabricksAccessConnector_basic (164.31s)
--- PASS: TestAccDatabricksAccessConnector_requiresImport (184.18s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/databricks	185.333s

favoretti · 2022-10-14T08:38:01Z

Failed test isn't related to either upgrade or the changes and seems to be transient. All the rest passes.

favoretti · 2022-10-14T08:38:33Z

@stephybun should be good to go for another review and potential merge. Would you take a look? Thanks a lot!

stephybun

A few minor comments on the error messages, other this is good to go!

internal/services/databricks/databricks_access_connector_resource.go

…rce.go Co-authored-by: stephybun <steph@hashicorp.com>

favoretti · 2022-10-14T10:57:21Z

Thanks for the suggestions, @stephybun, committed, once unit tests complete, we should be gtg.

stephybun

Thanks @favoretti LGTM 🧋

nfx · 2022-10-14T14:27:10Z

🥳

mvvsubbu · 2022-11-10T21:30:36Z

Thanks for this @favoretti! Since this is still in private preview I expected the tests to fail when trying to create the connector. Unfortunately it's created the connector in a failed state and currently can't be deleted. I'm going to mark this PR as blocked for the time being while we investigate this further.

Also just as an aside all resources within the provider will eventually need to be converted to typed resources for the gradual shift to using Pandora generated ones. Our contributor docs have a section on how to add new typed resources which will hopefully be helpful for future contributions 🙂.

I am from Azure Databricks Product group and I see the conversation about creation failing with SPN and Private Preview of the resource. Let me clarify those two issues here.

SPN support for Access Connector is enabled in mid of October.
Access Connector Resource is in Public Preview (Not Private Preview).

We have received a customer escalation about the resource being documented as Private Preview. Can you help us understand the process to update this to Public Preview.

https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/databricks_access_connector

github-actions · 2022-12-11T02:18:06Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added dependencies documentation service/databricks labels Oct 12, 2022

stephybun requested changes Oct 12, 2022

View reviewed changes

stephybun added the new-resource label Oct 12, 2022

stephybun added this to the Blocked milestone Oct 12, 2022

github-actions bot added the waiting-response label Oct 12, 2022

github-actions bot removed the waiting-response label Oct 12, 2022

favoretti added 4 commits October 13, 2022 10:48

New resource: azurerm_databricks_access_connector

503bc25

Also upgrade Databricks SDK to `2022-04-01-preview` I added acceptance tests, but feature is in private preview. Fixes hashicorp#18518

Fix a typo in docs

fa1b26b

Fix unit tests

760adf9

Rewrite as a typed resource

d9963f1

favoretti force-pushed the favoretti/dbrk_access_connector branch from d393af9 to d9963f1 Compare October 13, 2022 08:48

favoretti requested a review from stephybun October 13, 2022 09:25

favoretti added 2 commits October 14, 2022 10:14

Identity and registration fixes

8983c03

Identity and registration fixes

c25cd7e

stephybun reviewed Oct 14, 2022

View reviewed changes

github-actions bot added the waiting-response label Oct 14, 2022

favoretti and others added 2 commits October 14, 2022 12:31

Update internal/services/databricks/databricks_access_connector_resou…

ca5393d

…rce.go Co-authored-by: stephybun <steph@hashicorp.com>

Update internal/services/databricks/databricks_access_connector_resou…

2f2d6eb

…rce.go Co-authored-by: stephybun <steph@hashicorp.com>

Update internal/services/databricks/databricks_access_connector_resou…

1975251

…rce.go Co-authored-by: stephybun <steph@hashicorp.com>

github-actions bot removed the waiting-response label Oct 14, 2022

Update internal/services/databricks/databricks_access_connector_resou…

defb9d0

…rce.go Co-authored-by: stephybun <steph@hashicorp.com>

favoretti requested a review from stephybun October 14, 2022 10:57

stephybun approved these changes Oct 14, 2022

View reviewed changes

stephybun merged commit 54f23b8 into hashicorp:main Oct 14, 2022

stephybun added a commit that referenced this pull request Oct 14, 2022

Update for #18709

e7d664b

nkvuong mentioned this pull request Oct 21, 2022

Update Azure Unity Catalog guide to use azurerm_databricks_access_connector databricks/terraform-provider-databricks#1685

Merged

github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2022

stephybun modified the milestones: Blocked, v3.28.0 Mar 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New resource: `azurerm_databricks_access_connector` #18709

New resource: `azurerm_databricks_access_connector` #18709

favoretti commented Oct 12, 2022 •

edited

Loading

nfx commented Oct 12, 2022

favoretti commented Oct 12, 2022

stephybun left a comment

favoretti commented Oct 12, 2022

nfx commented Oct 13, 2022

favoretti commented Oct 13, 2022

favoretti commented Oct 13, 2022

favoretti commented Oct 14, 2022

favoretti commented Oct 14, 2022

favoretti commented Oct 14, 2022

favoretti commented Oct 14, 2022

stephybun left a comment

favoretti commented Oct 14, 2022

stephybun left a comment

nfx commented Oct 14, 2022

mvvsubbu commented Nov 10, 2022 •

edited

Loading

github-actions bot commented Dec 11, 2022

New resource: azurerm_databricks_access_connector #18709

New resource: azurerm_databricks_access_connector #18709

Conversation

favoretti commented Oct 12, 2022 • edited Loading

nfx commented Oct 12, 2022

favoretti commented Oct 12, 2022

stephybun left a comment

Choose a reason for hiding this comment

favoretti commented Oct 12, 2022

nfx commented Oct 13, 2022

favoretti commented Oct 13, 2022

favoretti commented Oct 13, 2022

favoretti commented Oct 14, 2022

favoretti commented Oct 14, 2022

favoretti commented Oct 14, 2022

favoretti commented Oct 14, 2022

stephybun left a comment

Choose a reason for hiding this comment

favoretti commented Oct 14, 2022

stephybun left a comment

Choose a reason for hiding this comment

nfx commented Oct 14, 2022

mvvsubbu commented Nov 10, 2022 • edited Loading

github-actions bot commented Dec 11, 2022

New resource: `azurerm_databricks_access_connector` #18709

New resource: `azurerm_databricks_access_connector` #18709

favoretti commented Oct 12, 2022 •

edited

Loading

mvvsubbu commented Nov 10, 2022 •

edited

Loading