Role Assignment/Definition: parsing the Resource ID's #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
$ acctests azurerm TestAccAzureRMRoleAssignment
=== RUN TestAccAzureRMRoleAssignment
=== RUN TestAccAzureRMRoleAssignment/basic
=== RUN TestAccAzureRMRoleAssignment/basic/builtin
=== RUN TestAccAzureRMRoleAssignment/basic/custom
=== RUN TestAccAzureRMRoleAssignment/basic/emptyName
=== RUN TestAccAzureRMRoleAssignment/basic/roleName
=== RUN TestAccAzureRMRoleAssignment/basic/dataActions
=== RUN TestAccAzureRMRoleAssignment/import
=== RUN TestAccAzureRMRoleAssignment/import/basic
=== RUN TestAccAzureRMRoleAssignment/import/custom
--- PASS: TestAccAzureRMRoleAssignment (706.95s)
--- PASS: TestAccAzureRMRoleAssignment/basic (280.44s)
--- PASS: TestAccAzureRMRoleAssignment/basic/builtin (71.61s)
--- PASS: TestAccAzureRMRoleAssignment/basic/custom (52.23s)
--- PASS: TestAccAzureRMRoleAssignment/basic/emptyName (42.97s)
--- PASS: TestAccAzureRMRoleAssignment/basic/roleName (55.43s)
--- PASS: TestAccAzureRMRoleAssignment/basic/dataActions (58.20s)
--- PASS: TestAccAzureRMRoleAssignment/import (426.51s)
--- PASS: TestAccAzureRMRoleAssignment/import/basic (364.16s)
--- PASS: TestAccAzureRMRoleAssignment/import/custom (62.35s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 707.329s
```
``` $ acctests azurerm TestAccAzureRMRoleDefinition === RUN TestAccAzureRMRoleDefinition_importBasic --- PASS: TestAccAzureRMRoleDefinition_importBasic (51.33s) === RUN TestAccAzureRMRoleDefinition_importComplete --- PASS: TestAccAzureRMRoleDefinition_importComplete (47.63s) === RUN TestAccAzureRMRoleDefinition_basic --- PASS: TestAccAzureRMRoleDefinition_basic (43.12s) === RUN TestAccAzureRMRoleDefinition_complete --- PASS: TestAccAzureRMRoleDefinition_complete (62.16s) === RUN TestAccAzureRMRoleDefinition_update --- PASS: TestAccAzureRMRoleDefinition_update (73.26s) === RUN TestAccAzureRMRoleDefinition_emptyName --- PASS: TestAccAzureRMRoleDefinition_emptyName (41.24s) PASS ```
ghost
added
the
This was referenced Sep 6, 2018
|
Role Assignment Tests pass: Role Definition Tests pass: |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches both Role Assignments and Role Definitions to parsing the Resource ID during the Delete function, which fixes a bug where the config is deleted (and thus resource deletion fails).
Supersedes #1724 and #1827
Fixes #1540