azurerm_spring_cloud_gateway_route_config - support for the protocol property

[ms-henglu]

[tombuildsstuff]

hi @ms-henglu

Thanks for this PR - I've taken a look through and whilst this PR looks good on the whole I think we need to think about the default value here, using HTTP as a default rather than HTTPS (or making this field Required, or not having a default value) is an insecure default -as such we probably need to change this default value.

Thanks!

[tombuildsstuff]

this is an insecure default, what's the reasoning for making this HTTP rather than HTTPS (or Required?)

[ms-henglu]

The server-side's default value is HTTP, if we make it default to HTTPS or required field. It will introduce breaking change.

[stephybun]

Can we make this field Required for 4.0 then and also add a note in the docs warning users that this is insecure by default.

[ms-henglu]

Thanks @stephybun , I've updated the PR, please take another look.

[stephybun]

Thanks @ms-henglu LGTM 🎺

[github-actions]

This functionality has been released in v3.34.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.