streamanalytics - switch to hashicorp/go-azure-sdk
#19395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackofallops
approved these changes
Nov 28, 2022
There was a problem hiding this comment.
Thanks @stephybun
Just a few possible changes needed, otherwise LGTM 🐮
internal/services/streamanalytics/stream_analytics_output_function_resource.go
Outdated
Show resolved
Hide resolved
internal/services/streamanalytics/stream_analytics_output_table_resource.go
Outdated
Show resolved
Hide resolved
internal/services/streamanalytics/stream_analytics_reference_input_blob_resource.go
Outdated
Show resolved
Hide resolved
internal/services/streamanalytics/stream_analytics_reference_input_mssql_resource.go
Outdated
Show resolved
Hide resolved
Comment on lines
-3
to
-9
| //go:generate go run ../../tools/generator-resource-id/main.go -path=./ -name=Function -id=/subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/resGroup1/providers/Microsoft.StreamAnalytics/streamingjobs/streamingJob1/functions/function1 | ||
| //go:generate go run ../../tools/generator-resource-id/main.go -path=./ -name=StreamingJob -id=/subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/resGroup1/providers/Microsoft.StreamAnalytics/streamingjobs/streamingJob1 | ||
| //go:generate go run ../../tools/generator-resource-id/main.go -path=./ -name=StreamingJobSchedule -id=/subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/resGroup1/providers/Microsoft.StreamAnalytics/streamingjobs/streamingJob1/schedule/default | ||
| //go:generate go run ../../tools/generator-resource-id/main.go -path=./ -name=StreamInput -id=/subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/resGroup1/providers/Microsoft.StreamAnalytics/streamingjobs/streamingJob1/inputs/streamInput1 | ||
| //go:generate go run ../../tools/generator-resource-id/main.go -path=./ -name=Output -id=/subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/resGroup1/providers/Microsoft.StreamAnalytics/streamingjobs/streamingJob1/outputs/output1 | ||
| //go:generate go run ../../tools/generator-resource-id/main.go -path=./ -name=Cluster -id=/subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/resGroup1/providers/Microsoft.StreamAnalytics/clusters/cluster1 | ||
| //go:generate go run ../../tools/generator-resource-id/main.go -path=./ -name=PrivateEndpoint -id=/subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/resGroup1/providers/Microsoft.StreamAnalytics/clusters/cluster1/privateEndpoints/endpoint1 |
There was a problem hiding this comment.
we're going to need state migrations for these, since go-azure-sdk uses the correct casing for these:
/subscriptions/%s/resourceGroups/%s/providers/Microsoft.StreamAnalytics/streamingJobs/%s
@stephybun any chance you could look into adding those?
harshavmb
pushed a commit
to AmadeusITGroup/terraform-provider-azurerm
that referenced
this pull request
Nov 28, 2022
* swap sdk for inputs and some outputs * swap remaining resources * modules * fix correct type assertions * revert changes to app service and firewall test * go mod vendor * update get opts for streaming jobs * fix type assertion for functions * tflint * fix condition * use custom importer and standardize error message for type assertions * fix tests * fix test * add todo and nil check properties
harshavmb
pushed a commit
to AmadeusITGroup/terraform-provider-azurerm
that referenced
this pull request
Nov 28, 2022
|
This functionality has been released in v3.34.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last commit fixes the test
TestAccStreamAnalyticsOutputTable_columnsToRemove.The other tests fail because of a limitation on the amount of clusters that can be spun up for our subscription and also fail on main.