Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kusto_database - allows underscores in name #19466

Merged
merged 2 commits into from Nov 29, 2022

Conversation

liuwuliuyun
Copy link
Contributor

@liuwuliuyun liuwuliuyun commented Nov 29, 2022

azurerm_kusto_database

@liuwuliuyun
Copy link
Contributor Author

GOROOT=C:\Program Files\Go #gosetup
GOPATH=C:\Users\yunliu1\go #gosetup
"C:\Program Files\Go\bin\go.exe" test -c -o C:\Users\yunliu1\AppData\Local\Temp\GoLand___TestAccKustoDatabase_name_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/kusto #gosetup
"C:\Program Files\Go\bin\go.exe" tool test2json -t C:\Users\yunliu1\AppData\Local\Temp\GoLand___TestAccKustoDatabase_name_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto.test.exe -test.v -test.paniconexit0 -test.run ^\QTestAccKustoDatabase_name\E$ #gosetup
=== RUN TestAccKustoDatabase_name
=== PAUSE TestAccKustoDatabase_name
=== CONT TestAccKustoDatabase_name
--- PASS: TestAccKustoDatabase_name (1284.48s)
PASS

Process finished with the exit code 0

@liuwuliuyun liuwuliuyun changed the title azurerm_kusto_database - allow underscores in name azurerm_kusto_database - allows underscores in name Nov 29, 2022
Co-authored-by: stephybun <steph@hashicorp.com>
@liuwuliuyun
Copy link
Contributor Author

Thanks for the review @stephybun

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liuwuliuyun LGTM 🐞

@stephybun stephybun merged commit 4209e90 into hashicorp:main Nov 29, 2022
@github-actions github-actions bot added this to the v3.34.0 milestone Nov 29, 2022
stephybun added a commit that referenced this pull request Nov 29, 2022
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

This functionality has been released in v3.34.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 2, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2023
@liuwuliuyun liuwuliuyun deleted the kusto_database_name_fix branch June 2, 2023 01:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not create azurerm_kusto_database with underscores (_) in the database name
2 participants