Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.azurerm_sentinel_alert_rule_template and azurerm_sentinel_automation_rule - a state migration to work around the previously incorrect id casing #19487

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

mbfrahry
Copy link
Member

No description provided.

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbfrahry LGTM 🦀

@mbfrahry mbfrahry added this to the v3.34.0 milestone Nov 30, 2022
@mbfrahry mbfrahry merged commit 43c768e into main Nov 30, 2022
@mbfrahry mbfrahry deleted the sm-sentinel-id branch November 30, 2022 17:49
mbfrahry added a commit that referenced this pull request Nov 30, 2022
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

This functionality has been released in v3.34.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ziyeqf
Copy link
Contributor

ziyeqf commented Dec 2, 2022

Hi @mbfrahry, Could you please confirm for this PR when does the service return a automationRules instead of AutomationRules in its id. I noticed the acctests are failing because the id returned by service can not be parsed at here (code link).The users should be facing the same issue, should we make a workaround here?

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants