Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_iothub_x - a state migration to work around the previously incorrect id casing #19524

Merged
merged 14 commits into from
Dec 2, 2022

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Dec 2, 2022

No description provided.

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbfrahry, few minor comments, otherwise LGTM 👍

ForceNew: true,
},

"resource_group_name": commonschema.ResourceGroupName(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be good to in-line these in case the behaviour changes

Comment on lines 30 to 40
// The condition is a string value representing device-to-cloud message routes query expression
// https://docs.microsoft.com/en-us/azure/iot-hub/iot-hub-devguide-query-language#device-to-cloud-message-routes-query-expressions
Type: pluginsdk.TypeString,
Optional: true,
Default: "true",
},

"endpoint_names": {
Type: pluginsdk.TypeList,
Required: true,
// Currently only one endpoint is allowed. With that comment from Microsoft, we'll leave this open to enhancement when they add multiple endpoint support.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pedantic, but I think comments like these can be removed?

@mbfrahry mbfrahry merged commit 6031d3a into main Dec 2, 2022
@mbfrahry mbfrahry deleted the sm-iothub-x-id branch December 2, 2022 23:12
mbfrahry added a commit that referenced this pull request Dec 2, 2022
@github-actions github-actions bot added this to the v3.35.0 milestone Dec 2, 2022
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

This functionality has been released in v3.35.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@hillen
Copy link
Contributor

hillen commented Dec 13, 2022

We have an azurerm_eventgrid_event_subscription resource that takes an azurerm_iothub resource id as the scope. The change of IotHubs to iotHubs on the azurerm_iothub id is causing terraform to want to delete and create the azurerm_eventgrid_event_subscription. Did you miss a migration on the azurerm_eventgrid_event_subscription scope?

favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this pull request Jan 12, 2023
favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this pull request Jan 12, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants