Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kusto_* - a state migration to work around the previously incorrect id casing #19525

Merged
merged 9 commits into from
Dec 2, 2022

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Dec 2, 2022

No description provided.

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbfrahry, one minor comments which I'm uncertain about and missed in the other state migration PRs, but otherwise LGTM 👍

Comment on lines 22 to 24
"resource_group_name": commonschema.ResourceGroupName(),

"location": commonschema.Location(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these need to be in-lined since it's a point in time reference?

Comment on lines 23 to 27
"resource_group_name": commonschema.ResourceGroupName(),

"location": commonschema.Location(),

"identity": commonschema.SystemAssignedUserAssignedIdentityOptional(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with these and any other refs to commonschema

@mbfrahry mbfrahry merged commit b117b4e into main Dec 2, 2022
@mbfrahry mbfrahry deleted the sm-kusto branch December 2, 2022 22:33
@github-actions github-actions bot added this to the v3.35.0 milestone Dec 2, 2022
mbfrahry added a commit that referenced this pull request Dec 2, 2022
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

This functionality has been released in v3.35.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants