Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_kubernetes_cluster azurerm_kubernetes_cluster_node_pool - support for the custom_ca_trust_enabled property #19546

Merged
merged 3 commits into from Dec 8, 2022
Merged

azurerm_kubernetes_cluster azurerm_kubernetes_cluster_node_pool - support for the custom_ca_trust_enabled property #19546

merged 3 commits into from Dec 8, 2022

Conversation

ms-henglu
Copy link
Contributor

@ms-henglu ms-henglu commented Dec 5, 2022 •
edited

Fixes #18391

stephybun
stephybun requested changes Dec 7, 2022
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu, this looks mostly fine, tests are passing, just a few minor comments left in-line.

internal/services/containers/kubernetes_cluster_other_resource_test.go Outdated Show resolved Hide resolved
website/docs/r/kubernetes_cluster_node_pool.html.markdown Outdated Show resolved Hide resolved
website/docs/r/kubernetes_cluster.html.markdown Outdated Show resolved Hide resolved
@ms-henglu @stephybun
Apply suggestions from code review
1d2271a 
Co-authored-by: stephybun <steph@hashicorp.com>
@ms-henglu @stephybun
Update website/docs/r/kubernetes_cluster_node_pool.html.markdown
5a1c41b 
Co-authored-by: stephybun <steph@hashicorp.com>
stephybun
stephybun approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu LGTM 🐿️

@stephybun stephybun merged commit 054e42f into hashicorp:main Dec 8, 2022
@github-actions github-actions bot added this to the v3.35.0 milestone Dec 8, 2022
stephybun added a commit that referenced this pull request Dec 8, 2022
@stephybun
Update for #19546
038f717
@dhirschfeld dhirschfeld mentioned this pull request Dec 9, 2022
Open
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

This functionality has been released in v3.35.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/kubernetes-cluster size/M
Projects
None yet
Milestone
v3.35.0
Development

Successfully merging this pull request may close these issues.

Support for --enable-custom-ca-trust for AKS clusters
2 participants
@ms-henglu @stephybun