Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_container_group - Fix dynamic setting dns_config crash issue #20002

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

sinbai
Copy link
Contributor

@sinbai sinbai commented Jan 13, 2023

dnsConfigRaw[0] should be checked for nil before dnsConfigRaw[0].(map[string]interface{}) to fix #19989.

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry modified the milestones: v4.0.0, v3.40.0 Jan 13, 2023
@mbfrahry mbfrahry merged commit 0efe996 into hashicorp:main Jan 13, 2023
mbfrahry added a commit that referenced this pull request Jan 13, 2023
@github-actions
Copy link

This functionality has been released in v3.40.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2023
@sinbai sinbai deleted the containers/fix_issue_19989 branch March 28, 2024 02:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container Instance with optional dns server causes crash
3 participants