Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_media_streaming_endpoint - correctly support tags, sku, and scale_units #20585

Merged
merged 4 commits into from
Feb 22, 2023

Conversation

teowa
Copy link
Contributor

@teowa teowa commented Feb 21, 2023

  • fix tags
  • export current_sku
  • change scale_units maxmium to 50
  • refactor to retrieve the existing and use d.HasChanges consistently in Update

Test:

make acctests SERVICE="media" TESTARGS="-parallel 50 -test.run=TestAccMediaStreamingEndpoint" TESTTIMEOUT='1440m' 
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/media -parallel 50 -test.run=TestAccMediaStreamingEndpoint -timeout 1440m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccMediaStreamingEndpoint_basic
=== PAUSE TestAccMediaStreamingEndpoint_basic
=== RUN   TestAccMediaStreamingEndpoint_CDN
=== PAUSE TestAccMediaStreamingEndpoint_CDN
=== RUN   TestAccMediaStreamingEndpoint_MaxCacheAge
=== PAUSE TestAccMediaStreamingEndpoint_MaxCacheAge
=== RUN   TestAccMediaStreamingEndpoint_shouldStopWhenStarted
=== PAUSE TestAccMediaStreamingEndpoint_shouldStopWhenStarted
=== RUN   TestAccMediaStreamingEndpoint_update
=== PAUSE TestAccMediaStreamingEndpoint_update
=== RUN   TestAccMediaStreamingEndpoint_standard
=== PAUSE TestAccMediaStreamingEndpoint_standard
=== CONT  TestAccMediaStreamingEndpoint_basic
=== CONT  TestAccMediaStreamingEndpoint_shouldStopWhenStarted
=== CONT  TestAccMediaStreamingEndpoint_standard
=== CONT  TestAccMediaStreamingEndpoint_MaxCacheAge
=== CONT  TestAccMediaStreamingEndpoint_CDN
=== CONT  TestAccMediaStreamingEndpoint_update
--- PASS: TestAccMediaStreamingEndpoint_standard (229.54s)
--- PASS: TestAccMediaStreamingEndpoint_MaxCacheAge (230.36s)
--- PASS: TestAccMediaStreamingEndpoint_CDN (234.82s)
--- PASS: TestAccMediaStreamingEndpoint_basic (236.53s)
--- PASS: TestAccMediaStreamingEndpoint_shouldStopWhenStarted (247.35s)
--- PASS: TestAccMediaStreamingEndpoint_update (325.54s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/media 325.588s

@teowa teowa changed the title azurerm_media_streaming_endpoint - azurerm_media_streaming_endpoint - correctly support tags, current_sku, and scale_units Feb 21, 2023
Co-authored-by: stephybun <steph@hashicorp.com>
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @teowa LGTM 👍

@stephybun stephybun merged commit bbbf034 into hashicorp:main Feb 22, 2023
@github-actions github-actions bot added this to the v3.45.0 milestone Feb 22, 2023
stephybun added a commit that referenced this pull request Feb 22, 2023
@github-actions
Copy link

This functionality has been released in v3.45.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@teowa teowa changed the title azurerm_media_streaming_endpoint - correctly support tags, current_sku, and scale_units azurerm_media_streaming_endpoint - correctly support tags, sku, and scale_units Feb 24, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants