Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_media_services_account: fix crash around key_delivery_access_control #20685

Merged
merged 5 commits into from
Mar 2, 2023
Merged

azurerm_media_services_account: fix crash around key_delivery_access_control #20685

merged 5 commits into from
Mar 2, 2023

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Feb 28, 2023 •
edited
Loading

fix #20645
Screenshot 2023-02-28 at 14 14 48

@github-actions
Copy link

Build failure

Found new usages of deprecated functionality:

https://github.com/hashicorp/terraform-provider-azurerm/actions/runs/4289766316

@ziyeqf ziyeqf mentioned this pull request Feb 28, 2023
Closed
1 task
@github-actions
Copy link

Build failure

Found new usages of deprecated functionality:

https://github.com/hashicorp/terraform-provider-azurerm/actions/runs/4289987235

@ziyeqf
Copy link
Contributor Author

ziyeqf commented Feb 28, 2023 •
edited
Loading

the ci failure will be fixed on #20685

CI failure fixed

@ziyeqf ziyeqf force-pushed the tengzh/issue/media_services_crash branch from fc6abcb to 8c8a5d6 Compare February 28, 2023 11:08
mbfrahry
mbfrahry requested changes Feb 28, 2023
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ziyeqf, this does fix the crash but we can do it a little better by adding to this line here

if len(input) == 0 || input[0] == nil {
	return nil
}

mbfrahry
mbfrahry approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbfrahry mbfrahry changed the title azurerm_media_services_account: fix crash azurerm_media_services_account: fix crash around key_delivery_access_control Mar 2, 2023
@mbfrahry mbfrahry merged commit 12bde77 into hashicorp:main Mar 2, 2023
mbfrahry added a commit that referenced this pull request Mar 2, 2023
@mbfrahry
Update changelog for #20685
b2519ee
@github-actions github-actions bot added this to the v3.46.0 milestone Mar 2, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

This functionality has been released in v3.46.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
service/media size/XS
Projects
None yet
Milestone
v3.46.0
Development

Successfully merging this pull request may close these issues.

azurerm_media_services_account causes plugin to crash
2 participants
@ziyeqf @mbfrahry