Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_iothub_endpoint_* azurerm_iothub_route - set Id to nil when resource is not found #20798

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Mar 6, 2023

These are extracted resources from azurerm_iothub and use certain properties from an IoT Hub. When removed outside of Terraform, the read fails directly instead of recreating the resource. Adding the logic to set the ID to empty string when IoTHub or the endpoint/route itself are removed so that they could be recreated in Terraform

@myc2h6o myc2h6o changed the title iothub_ednpoint_* iothub_route - fix read/recreate when deleted outside iothub_endpoint_* iothub_route - fix read/recreate when deleted outside Mar 6, 2023
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title iothub_endpoint_* iothub_route - fix read/recreate when deleted outside azurerm_iothub_endpoint_* azurerm_iothub_route - set Id to nil when resource is not found Mar 6, 2023
@mbfrahry mbfrahry added this to the v3.47.0 milestone Mar 6, 2023
@mbfrahry mbfrahry merged commit b41e246 into hashicorp:main Mar 6, 2023
mbfrahry added a commit that referenced this pull request Mar 6, 2023
@myc2h6o myc2h6o deleted the iothub_nil_id branch March 7, 2023 02:52
tombuildsstuff added a commit that referenced this pull request Mar 7, 2023
jackofallops pushed a commit to xiaxyi/terraform-provider-azurerm that referenced this pull request Mar 7, 2023
jackofallops pushed a commit to xiaxyi/terraform-provider-azurerm that referenced this pull request Mar 7, 2023
@github-actions
Copy link

This functionality has been released in v3.47.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants