Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_[linux|windows]_function_app_slot - fix health_check_eviction_time_in_min #20816

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

jackofallops
Copy link
Member

  • azurerm_linux_function_app_slot - fix health_check_eviction_time_in_min
  • azurerm_windows_function_app_slot - fix health_check_eviction_time_in_min

fixes #16302

Note: Default value here is outside the bounds of the validation as this value deactivates the health check.

@jackofallops jackofallops requested a review from a team March 7, 2023 06:13
@jackofallops jackofallops self-assigned this Mar 7, 2023
@jackofallops
Copy link
Member Author

Tests look good:

image

Copy link
Member

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackofallops jackofallops merged commit 8961fdd into main Mar 7, 2023
@jackofallops jackofallops deleted the b/function-app-slots-healthcheck-timeout branch March 7, 2023 17:20
@github-actions github-actions bot added this to the v3.47.0 milestone Mar 7, 2023
jackofallops added a commit that referenced this pull request Mar 7, 2023
@github-actions
Copy link

This functionality has been released in v3.47.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

health_check_eviction_time_in_min is not applied to azurerm_linux_web_app in site_config block
2 participants