Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth_settings_v2 on azurerm_windows_web_app doesn't allow to set 0 value of token_refresh_extension_time login block field #21006

Closed
1 task done
michaelquintela opened this issue Mar 17, 2023 · 3 comments
Assignees

Comments

@michaelquintela
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

1.3.7

AzureRM Provider Version

3.45.0

Affected Resource(s)/Data Source(s)

azurerm_web_app

Terraform Configuration Files

resource "azurerm_windows_web_app" "web_app" {
  provider = azurerm.GSS_pay_as_you_go
  name = module.common.resource_name
  resource_group_name = module.common.resource_name
  location = data.azurerm_service_plan.app_service_plan.location
  service_plan_id = data.azurerm_service_plan.app_service_plan.id
  https_only = true
  tags = local.tags
  auth_settings_v2 {
    auth_enabled = true
    default_provider = "aad"
    runtime_version = "~1"
    unauthenticated_action = "RedirectToLoginPage"
    active_directory_v2{
      client_id = local.ad_app_id
      login_parameters = {}
      tenant_auth_endpoint = "https://login.microsoftonline.com/${module.common.ad_tenant_id}/v2.0"
      www_authentication_disabled  = false
    }
    login{
      token_store_enabled = true
      # issue: not allow to set 0.
      token_refresh_extension_time = 0
    }
  }
  site_config {}
}

Debug Output/Panic Output

error: expected auth_settings_v2.0.login.0.token_refresh_extension_time to be atlist (1.0000), got (0.00000)

Expected Behaviour

The provider should allow to set 0 value of auth_settings_v2.0.login.0.token_refresh_extension_time.

Actual Behaviour

A validation error occurred when we set 0 value of auth_settings_v2.0.login.0.token_refresh_extension_time.

Steps to Reproduce

Upgrade Azure on auth v2 from portal.
Now, run terraform plan or terraform apply command.
Observed, it’s through an error.

Note: Here, se can set token_refresh_extension_time value 0 from azure portal.

Please refer attached screenshot for more information:
image

Important Factoids

No response

References

No response

@michaelquintela michaelquintela changed the title auth_settings_v2 on azurerm_windows_web_app not allow to set 0 value of token_refresh_extension_time login block field auth_settings_v2 on azurerm_windows_web_app doesn't allow to set 0 value of token_refresh_extension_time login block field Mar 17, 2023
@jackofallops jackofallops self-assigned this Mar 20, 2023
@catriona-m
Copy link
Member

Thanks for raising this issue - it looks like this has now been fixed in #21013 so this can be closed now. Thanks!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants