Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Virtual Desktop: load balancer type #21102

Closed
1 task done
marcvalk-git opened this issue Mar 23, 2023 · 3 comments
Closed
1 task done

Azure Virtual Desktop: load balancer type #21102

marcvalk-git opened this issue Mar 23, 2023 · 3 comments

Comments

@marcvalk-git
Copy link

marcvalk-git commented Mar 23, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Why does changing the load_balancer_type value from (i.e.) BreadthFirst to DepthFirst cause a creation of a new resource ?

Documentation states:
load_balancer_type - (Required) BreadthFirst load balancing distributes new user sessions across all available session hosts in the host pool. Possible values are BreadthFirst, DepthFirst and Persistent. Changing this forces a new resource to be created.

If you change this inside the portal, it just updates and does not create a new resource (as far as I can see)

Terraform Version

1.4.2

AzureRM Provider Version

3.48.0

Affected Resource(s)/Data Source(s)

azurerm_virtual_desktop_host_pool

Terraform Configuration Files

resource "azurerm_virtual_desktop_host_pool" "this" {
  name                     = "vdpool"
  resource_group_name      = "rg-001"
  location                 = "westeurope
  type                     = "Pooled"
  load_balancer_type       = "BreadthFirst"
  friendly_name            = "friendly name"
  description              = "description"
  validate_environment     = true
  maximum_sessions_allowed = 16
}

Debug Output/Panic Output

# azurerm_virtual_desktop_host_pool.this must be replaced
-/+ resource "azurerm_virtual_desktop_host_pool" "this" {
      ~ id                       = "/subscriptions/***/resourceGroups/rg-001/providers/Microsoft.DesktopVirtualization/hostPools/vdpool" -> (known after apply)
      ~ **load_balancer_type       = "BreadthFirst" -> "DepthFirst" # forces replacement**
        name                     = "vdpool"
        # (10 unchanged attributes hidden)
    }

Expected Behaviour

azurerm_virtual_desktop_host_pool.this must be replaced

-/+ resource "azurerm_virtual_desktop_host_pool" "this" {
~ id = "/subscriptions/***/resourceGroups/rg-001/providers/Microsoft.DesktopVirtualization/hostPools/vdpool" -> (known after apply)
~ load_balancer_type = "BreadthFirst" -> "DepthFirst" # forces replacement
name = "vdpool"

    # (10 unchanged attributes hidden)
}

Actual Behaviour

azurerm_virtual_desktop_host_pool.this must be replaced

-/+ resource "azurerm_virtual_desktop_host_pool" "this" {
~ id = "/subscriptions/***/resourceGroups/rg-001/providers/Microsoft.DesktopVirtualization/hostPools/vdpool" -> (known after apply)
~ load_balancer_type = "BreadthFirst" -> "DepthFirst" # forces replacement
name = "vdpool"
# (10 unchanged attributes hidden)
}

Steps to Reproduce

No response

Important Factoids

No response

References

No response

@github-actions github-actions bot removed the bug label Mar 23, 2023
@sinbai
Copy link
Contributor

sinbai commented Mar 24, 2023

@marcvalk-git thanks for opening this issue. This issue means that a change of load_balancer_type should not force the creation of a new resource, correct? If yes, this issue has been fixed by PR #20947 and released in v3.49.0 of the Terraform Provider. Could you upgrade the tf version to see if it has been resolved?

@marcvalk-git
Copy link
Author

result of test with v.3.49.0:

azurerm_virtual_desktop_host_pool.avd_hostpool will be updated in-place 👍🏻

thank you.

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants