Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_log_analytics_linked_service - fix the validation of workspace_id #21170

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Mar 29, 2023

Recently, below test cases are failed in teamcity. I found workspace_id is using incorrect validation. See more details from this PR.
image

So I raised this PR and here is the test result.
image

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -215,7 +215,7 @@ func resourceLogAnalyticsLinkedServiceSchema() map[string]*pluginsdk.Schema {
Type: pluginsdk.TypeString,
Required: true,
DiffSuppressFunc: suppress.CaseDifference,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this suppressing the casing here? we should be able to remove this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't add it. I have no context about it. After DiffSuppressFunc is removed, seems test cases still passed. So I removed this attribute.

--- PASS: TestAccLogAnalyticsLinkedService_basic (287.65s)
--- PASS: TestAccLogAnalyticsLinkedService_requiresImport (266.62s)
--- PASS: TestAccLogAnalyticsLinkedService_complete (245.27s)

@tombuildsstuff tombuildsstuff added this to the v3.50.0 milestone Mar 29, 2023
@tombuildsstuff tombuildsstuff merged commit dd4b170 into hashicorp:main Mar 29, 2023
tombuildsstuff added a commit that referenced this pull request Mar 29, 2023
@github-actions
Copy link

This functionality has been released in v3.50.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants