-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_log_analytics_linked_service - fix the validation of workspace_id #21170
azurerm_log_analytics_linked_service - fix the validation of workspace_id #21170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@@ -215,7 +215,7 @@ func resourceLogAnalyticsLinkedServiceSchema() map[string]*pluginsdk.Schema { | |||
Type: pluginsdk.TypeString, | |||
Required: true, | |||
DiffSuppressFunc: suppress.CaseDifference, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this suppressing the casing here? we should be able to remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't add it. I have no context about it. After DiffSuppressFunc is removed, seems test cases still passed. So I removed this attribute.
--- PASS: TestAccLogAnalyticsLinkedService_basic (287.65s)
--- PASS: TestAccLogAnalyticsLinkedService_requiresImport (266.62s)
--- PASS: TestAccLogAnalyticsLinkedService_complete (245.27s)
This functionality has been released in v3.50.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Recently, below test cases are failed in teamcity. I found workspace_id is using incorrect validation. See more details from this PR.
![image](https://user-images.githubusercontent.com/19754191/228396865-0e8ca3df-b00e-415f-b401-bc67ce45f51c.png)
So I raised this PR and here is the test result.
![image](https://user-images.githubusercontent.com/19754191/228397183-82ccd6d8-1f5b-4007-ae61-30c584de150f.png)