azurerm_app_configuration_feature - support key property

[teowa]

resolves #20985
The key is generated from the feature flag name by default, this PR export a customizable key property, which support : character in feature key. From Portal:

test:

[stephybun]

Thanks for this @teowa

We have a test failure though

------- Stdout: -------
=== RUN   TestAccAppConfigurationFeature_noLabelUpdate
=== PAUSE TestAccAppConfigurationFeature_noLabelUpdate
=== CONT  TestAccAppConfigurationFeature_noLabelUpdate
testcase.go:110: Step 3/4 error: After applying this test step, the plan was not empty.
stdout:
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# azurerm_app_configuration_feature.test will be updated in-place
~ resource "azurerm_app_configuration_feature" "test" {
~ enabled                 = true -> false
id                      = "https://testacc-appconf230403091031840358.azconfig.io/kv/.appconfig.featureflag%2Facctest-ackey-230403091031840358?label=
name                    = "acctest-ackey-230403091031840358"
tags                    = {}
# (5 unchanged attributes hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccAppConfigurationFeature_noLabelUpdate (163.47s)
FAIL

[teowa]

the test failure should be caused by unstable API.

[stephybun]

@teowa if there's an issue on the API side we should raise it with the service team - is there a ticket open on the swagger repo?

[teowa]

@teowa if there's an issue on the API side we should raise it with the service team - is there a ticket open on the swagger repo?

I should be more specific, the provided test failure seems hard to reproduce, I have re-run the tests for several times but all test pass. I guess it might be caused by things behind of the provider, like network or unstable API. So I am not sure in this case I can open a ticket on swagger repo.

[stephybun]

Thanks @teowa, two comments on the docs which I overlooked yesterday, the validation is caught/checked by the schema, we don't need to outline it in the docs. Once that's fixed up this should be good to go!

[teowa]

Hi @stephybun, thanks for reviewing this. I have changed the code per review comment, please take another look. Thanks.

[stephybun]

Thanks for making those updates @teowa. LGTM 👍

[github-actions]

This functionality has been released in v3.51.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!